Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: Source/bindings/core/v8/generated.gyp

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/BUILD.gn ('k') | Source/bindings/modules/v8/generated.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/generated.gyp
diff --git a/Source/bindings/core/v8/generated.gyp b/Source/bindings/core/v8/generated.gyp
index 6a61c2e7a4da4a21776f49251ab2f938061acb4a..36d42d89b9d4d90dc306cd5092d7fa8c7ab1dc6a 100644
--- a/Source/bindings/core/v8/generated.gyp
+++ b/Source/bindings/core/v8/generated.gyp
@@ -51,10 +51,8 @@
'msvs_external_rule': 1,
'inputs': [
'<@(idl_lexer_parser_files)', # to be explicit (covered by parsetab)
+ '<@(idl_cache_files)',
'<@(idl_compiler_files)',
- '<(bindings_scripts_output_dir)/lextab.py',
- '<(bindings_scripts_output_dir)/parsetab.pickle',
- '<(bindings_scripts_output_dir)/cached_jinja_templates.stamp',
'<(bindings_dir)/IDLExtendedAttributes.txt',
# If the dependency structure or public interface info (e.g.,
# [ImplementedAs]) changes, we rebuild all files, since we're not
@@ -122,10 +120,64 @@
},
################################################################################
{
+ # GN version: //third_party/WebKit/Source/bindings/core/v8:bindings_core_dictionary_impl_generated
+ # http://crbug.com/358074; See comments on
+ # 'bindings_core_v8_generated_individual' target
+ 'target_name': 'bindings_core_dictionary_impl_generated',
+ 'type': 'none',
+ 'hard_dependency': 1,
+ 'dependencies': [
+ '<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
+ '<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
+ '../../modules/generated.gyp:interfaces_info',
+ ],
+ 'sources': [
+ # FIXME: Add '<@(core_dictionary_idl_files)',
+ # See comment on core/core.gypi
+ '<@(core_testing_dictionary_idl_files)',
+ ],
+ 'actions': [{
+ 'action_name': 'idl_dictionary',
+ # Mark as explicit idl action to prevent MSVS emulation on Windows.
+ 'explicit_idl_action': 1,
+ 'msvs_cygwin_shell': 0,
+ 'inputs': [
+ '<@(core_testing_dictionary_idl_files)',
+ '<@(idl_lexer_parser_files)',
+ '<@(idl_cache_files)',
+ '<@(idl_compiler_files)',
+ '<(bindings_dir)/IDLExtendedAttributes.txt',
+ '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+ ],
+ 'outputs': [
+ # FIXME: Add '<@(generated_core_dictionary_files)',
+ # See comment on core/core.gypi
+ '<@(generated_core_testing_dictionary_files)',
+ ],
+ 'action': [
+ 'python',
+ '<(bindings_scripts_dir)/idl_compiler.py',
+ '--cache-dir',
+ '<(bindings_scripts_output_dir)',
+ '--output-dir',
+ '<(SHARED_INTERMEDIATE_DIR)/blink/',
+ '--interfaces-info',
+ '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+ '--write-file-only-if-changed',
+ '<(write_file_only_if_changed)',
+ '--generate-dictionary-impl',
+ '<(core_dictionary_idl_files_list)',
+ ],
+ 'message': 'Generating core IDL dictionary impl classes',
+ }],
+ },
+################################################################################
+ {
# GN version: //third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated
'target_name': 'bindings_core_v8_generated',
'type': 'none',
'dependencies': [
+ 'bindings_core_dictionary_impl_generated',
'bindings_core_v8_generated_aggregate',
'bindings_core_v8_generated_individual',
],
« no previous file with comments | « Source/bindings/core/v8/BUILD.gn ('k') | Source/bindings/modules/v8/generated.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698