Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: Source/core/core.gypi

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index dbefb358446305335fdac8ef8a109cd1b846ca2e..e02483fa45ac815d3077ca7bae7015b48b5f308c 100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -3324,7 +3324,23 @@
'svg/properties/SVGAnimatedProperty.cpp',
'svg/properties/SVGPropertyTearOff.cpp',
],
+ # FIXME: http://crbug.com/403150
+ # Add 'core_dictionary_idl_files' and
+ # 'generated_core_dictionary_files' variables.
+ # The variables should contain IDL dictionary files and generated files
+ # They would look like below:
+ # 'core_dictionary_idl_files': [
+ # 'css/FontFaceDescriptors.idl',
+ # ],
+ # 'generated_core_dictionary_files': [
+ # '<(blink_core_output_dir)/css/FontFaceDescriptors.cpp',
+ # '<(blink_core_output_dir)/css/FontFaceDescriptors.h',
+ # ],
+ 'core_testing_dictionary_idl_files': [
+ 'testing/TestingDictionary.idl',
haraken 2014/08/27 08:37:39 Probably it's slightly better to rename testing/Te
bashi 2014/08/27 10:54:01 I'd like to avoid "Dictionary" because it sounds g
haraken 2014/08/27 10:54:45 InternalDictionary sounds good.
+ ],
'webcore_testing_idl_files': [
+ 'testing/DictionaryTest.idl',
'testing/GarbageCollectedScriptWrappable.idl',
'testing/GCObservation.idl',
'testing/InternalProfilers.idl',
@@ -3343,9 +3359,15 @@
'<(blink_core_output_dir)/InternalRuntimeFlags.idl',
'<(blink_core_output_dir)/InternalSettingsGenerated.idl',
],
+ 'generated_core_testing_dictionary_files': [
+ '<(blink_core_output_dir)/testing/TestingDictionary.cpp',
+ '<(blink_core_output_dir)/testing/TestingDictionary.h',
+ ],
'webcore_testing_files': [
'<(blink_core_output_dir)/InternalSettingsGenerated.cpp',
'<(blink_core_output_dir)/InternalSettingsGenerated.h',
+ 'testing/DictionaryTest.cpp',
+ 'testing/DictionaryTest.h',
'testing/DummyPageHolder.cpp',
'testing/DummyPageHolder.h',
'testing/GarbageCollectedScriptWrappable.cpp',

Powered by Google App Engine
This is Rietveld 408576698