Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index 04e11e52affbb19d1de8d725e392d53819c298d1..56bbdf90981bfba00b9d611ff6475388f8e58800 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -43,7 +43,7 @@ import bindings.scripts.compute_interfaces_info_individual
from bindings.scripts.compute_interfaces_info_individual import compute_info_individual, info_individual
import bindings.scripts.compute_interfaces_info_overall
from bindings.scripts.compute_interfaces_info_overall import compute_interfaces_info_overall, interfaces_info
-from bindings.scripts.idl_compiler import IdlCompilerV8
+from bindings.scripts.idl_compiler import IdlCompilerDictionaryImpl, IdlCompilerV8
PASS_MESSAGE = 'All tests PASS!'
@@ -192,6 +192,9 @@ def bindings_tests(output_directory, verbose):
idl_compiler = IdlCompilerV8(output_directory,
interfaces_info=interfaces_info,
only_if_changed=True)
+ dictionary_impl_compiler = IdlCompilerDictionaryImpl(
+ output_directory, interfaces_info=interfaces_info,
+ only_if_changed=True, use_relative_output_path=False)
idl_basenames = [filename
for filename in os.listdir(test_input_directory)
@@ -203,6 +206,10 @@ def bindings_tests(output_directory, verbose):
idl_path = os.path.realpath(
os.path.join(test_input_directory, idl_basename))
idl_compiler.compile_file(idl_path)
+ definition_name, _ = os.path.splitext(idl_basename)
+ if (definition_name in interfaces_info and
+ interfaces_info[definition_name]['is_dictionary']):
+ dictionary_impl_compiler.compile_file(idl_path)
if verbose:
print 'Compiled: %s' % filename
finally:
« Source/core/testing/Internals.idl ('K') | « Source/core/testing/TestingDictionary.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698