LayoutTests/fast/dom/idl-dictionary-unittest.html - Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/idl-dictionary-unittest.html

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description('IDL dictionary unittest');

	5

	6 if (window.internals && internals.dictionaryTest) {

	7 var dictionaryTest = window.internals.dictionaryTest();

	8

	9 dictionaryTest.set({});

	10 dict = dictionaryTest.get();

	11 shouldBeUndefined('dict.longMember');

	12 shouldBe('dict.stringMember', '"defaultStringValue"');
	haraken 2014/08/26 04:00:40 shouldBeEqualToString shouldBeEqualToString bashi 2014/08/27 05:06:31 Done. Show quoted text On 2014/08/26 04:00:40, haraken wrote: > > shouldBeEqualToString Done.
	13 shouldBeNull('dict.booleanOrNullMember');

	14

	15 dictionaryTest.set({longMember: 3, stringMember: 'modifiedString',

	16 stringSequenceMember: ['foo', 'bar', 'baz'],

	17 invalidMember: 'invalid'});
	haraken 2014/08/26 04:00:40 I want to add more test cases about null, undefine I want to add more test cases about null, undefined, missing members etc. bashi 2014/08/27 05:06:31 Partially done. Not all tests passed and it's not Show quoted text On 2014/08/26 04:00:40, haraken wrote: > > I want to add more test cases about null, undefined, missing members etc. Partially done. Not all tests passed and it's not trivial to fix so I'd like to make another CL to fix them.
	18 dict = dictionaryTest.get();

	19 shouldBe('dict.longMember', '3');

	20 shouldBe('dict.stringMember', '"modifiedString"');
	haraken 2014/08/26 04:00:40 shouldBeEqualToString shouldBeEqualToString bashi 2014/08/27 05:06:31 Done. Show quoted text On 2014/08/26 04:00:40, haraken wrote: > > shouldBeEqualToString Done.
	21 shouldBe('dict.stringSequenceMember', '["foo", "bar", "baz"]');

	22 shouldBeUndefined('dict.invalidMember');

	23 }

	24 </script>

OLD	NEW