IDL: Add build target for IDL dictionary impl generation in core

Source/core/core.gypi

 {
     'includes': [
       'core_generated.gypi',
     ],
     'variables': {
         # Files for which bindings (.cpp and .h files) will be generated
         'core_idl_files': [
             'animation/Animation.idl',
             'animation/AnimationEffect.idl',
             'animation/AnimationPlayer.idl',
@@ skipping 3307 matching lines @@
             'svg/graphics/SVGImageForContainer.h',
             'svg/graphics/filters/SVGFEImage.cpp',
             'svg/graphics/filters/SVGFEImage.h',
             'svg/graphics/filters/SVGFilter.cpp',
             'svg/graphics/filters/SVGFilter.h',
             'svg/graphics/filters/SVGFilterBuilder.cpp',
             'svg/graphics/filters/SVGFilterBuilder.h',
             'svg/properties/SVGAnimatedProperty.cpp',
             'svg/properties/SVGPropertyTearOff.cpp',
         ],
+        # FIXME: http://crbug.com/403150
+        # Add 'core_dictionary_idl_files' and
+        # 'generated_core_dictionary_files' variables.
+        # The variables should contain IDL dictionary files and generated files
+        # They would look like below:
+        # 'core_dictionary_idl_files': [
+        #   'css/FontFaceDescriptors.idl',
+        # ],
+        # 'generated_core_dictionary_files': [
+        #   '<(blink_core_output_dir)/css/FontFaceDescriptors.cpp',
+        #   '<(blink_core_output_dir)/css/FontFaceDescriptors.h',
+        # ],
+        'core_testing_dictionary_idl_files': [
+          'testing/TestingDictionary.idl',
+        ],
         'webcore_testing_idl_files': [
+          'testing/DictionaryTest.idl',
           'testing/GarbageCollectedScriptWrappable.idl',
           'testing/GCObservation.idl',
           'testing/InternalProfilers.idl',
           'testing/InternalSettings.idl',
           'testing/Internals.idl',
           'testing/LayerRect.idl',
           'testing/LayerRectList.idl',
           'testing/PrivateScriptTest.idl',
           'testing/RefCountedScriptWrappable.idl',
           'testing/TypeConversions.idl',
         ],
         'webcore_testing_dependency_idl_files': [
           'testing/PartialPrivateScriptTest.idl',
         ],
         'generated_webcore_testing_idl_files': [
           '<(blink_core_output_dir)/InternalRuntimeFlags.idl',
           '<(blink_core_output_dir)/InternalSettingsGenerated.idl',
         ],
+        'generated_core_testing_dictionary_files': [
+          '<(blink_core_output_dir)/testing/TestingDictionary.cpp',
+          '<(blink_core_output_dir)/testing/TestingDictionary.h',
+        ],
         'webcore_testing_files': [
+            '<@(generated_core_testing_dictionary_files)',

[brettw, 2014/08/14 22:26:29]

Unless I'm misunderstanding something, I'm surprised this runs at all.  In
core.gni, this file gets slurped in and you assign this to
webcore_testing_files. But this will include this literal. Then when we call
get_path_info it will be converted to
"//third_party/WebKit/Source/core/<@(generated_core_testing_dictionary_files)"
which will then get passed around.

You should be able to verify this by just print(webcore_testing_files) in the
.gni file and running gn: "gn gen out/eraseme"

If you need this in GYP, you have to remove the '<@...' string from the list,
and you have to do it before calling get_path_info (well, you could do it after,
but then you would need to include the whole "//third_party/..." thing above
which is pretty weird.

You can see some code in Source/bindings/bindings.gni that does this. It
assignes to a temporary (beginning with _ to mark it as file-local) and then
subtracts the string from there.

[bashi, 2014/08/15 00:14:54]

Thank you for the detailed explanation! I removed
'<@(generated_core_testing_dictionary_files)' from here and added it in
'sources' of 'webcore_testing'. (Did it for GN as well).

             '<(blink_core_output_dir)/InternalSettingsGenerated.cpp',
             '<(blink_core_output_dir)/InternalSettingsGenerated.h',
+            'testing/DictionaryTest.cpp',
+            'testing/DictionaryTest.h',
             'testing/DummyPageHolder.cpp',
             'testing/DummyPageHolder.h',
             'testing/GarbageCollectedScriptWrappable.cpp',
             'testing/GarbageCollectedScriptWrappable.h',
             'testing/GCObservation.cpp',
             'testing/GCObservation.h',
             'testing/InternalProfilers.cpp',
             'testing/InternalProfilers.h',
             'testing/InternalSettings.cpp',
             'testing/InternalSettings.h',
@@ skipping 106 matching lines @@
             'rendering/shapes/BoxShapeTest.cpp',
             'rendering/style/OutlineValueTest.cpp',
             'testing/PrivateScriptTestTest.cpp',
             'streams/ReadableStreamTest.cpp',
             'testing/UnitTestHelpers.cpp',
             'testing/UnitTestHelpers.h',
             'xml/parser/SharedBufferReaderTest.cpp',
         ],
     }
 }