IDL: Add build target for IDL dictionary impl generation in core

Source/bindings/scripts/code_generator_v8.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 62 matching lines @@
 import idl_types
 from idl_types import IdlType
 import v8_callback_interface
 import v8_dictionary
 from v8_globals import includes, interfaces
 import v8_interface
 import v8_types
 from v8_utilities import capitalize, cpp_name, conditional_string, v8_class_name
 
 
+# Code generation mode.
+MODE_BINDINGS = 1 << 0
+MODE_DICTIONARY_IMPL = 1 << 1
+MODE_ALL = MODE_BINDINGS | MODE_DICTIONARY_IMPL
+
+
 def render_template(interface_info, header_template, cpp_template,
                     template_context):
     template_context['code_generator'] = module_pyname
 
     # Add includes for any dependencies
     template_context['header_includes'] = sorted(
         template_context['header_includes'])
     includes.update(interface_info.get('dependencies_include_paths', []))
     template_context['cpp_includes'] = sorted(includes)
 
@@ skipping 37 matching lines @@
         v8_types.set_component_dirs(dict(
             (interface_name, interface_info['component_dir'])
             for interface_name, interface_info in interfaces_info.iteritems()))
 
     def output_paths_for_bindings(self, definition_name):
         header_path = posixpath.join(self.output_dir,
                                      'V8%s.h' % definition_name)
         cpp_path = posixpath.join(self.output_dir, 'V8%s.cpp' % definition_name)
         return header_path, cpp_path
 
-    def output_paths_for_impl(self, definition_name):
-        header_path = posixpath.join(self.output_dir, '%s.h' % definition_name)
-        cpp_path = posixpath.join(self.output_dir, '%s.cpp' % definition_name)
+    def output_paths_for_impl(self, definition_name, relative_dir):
+        output_dir = posixpath.join(self.output_dir, relative_dir)
+        header_path = posixpath.join(output_dir, '%s.h' % definition_name)
+        cpp_path = posixpath.join(output_dir, '%s.cpp' % definition_name)
         return header_path, cpp_path
 
-    def generate_code(self, definitions, definition_name):
+    def generate_code(self, definitions, definition_name,
+                      mode=MODE_ALL):

[bashi, 2014/07/30 11:32:26]

BTW, this is ugly. I'm now thinking that it'd be better to split bindings
generator and dictionary impl generator if we pass a command line flag to
idl_compiler ("--generate-dictionary-impl" in this CL) to indicate what code the
code generator should generate.

[haraken, 2014/07/30 19:57:36]

That seems better to me (assuming that it won't duplicate the generate_code
function a lot).

         """Returns .h/.cpp code as (header_text, cpp_text)."""
         # Set local type info
         IdlType.set_callback_functions(definitions.callback_functions.keys())
         IdlType.set_enums((enum.name, enum.values)
                           for enum in definitions.enumerations.values())
 
         if definition_name in definitions.interfaces:
             return self.generate_interface_code(
                 definitions, definition_name,
                 definitions.interfaces[definition_name])
         if definition_name in definitions.dictionaries:
             return self.generate_dictionary_code(
                 definitions, definition_name,
-                definitions.dictionaries[definition_name])
+                definitions.dictionaries[definition_name], mode)
         raise ValueError('%s is not in IDL definitions' % definition_name)
 
     def generate_interface_code(self, definitions, interface_name, interface):
         # Store other interfaces for introspection
         interfaces.update(definitions.interfaces)
 
         # Select appropriate Jinja template and contents function
         if interface.is_callback:
             header_template_filename = 'callback_interface.h'
             cpp_template_filename = 'callback_interface.cpp'
@@ skipping 12 matching lines @@
         template_context['header_includes'].add(interface_info['include_path'])
         header_text, cpp_text = render_template(
             interface_info, header_template, cpp_template, template_context)
         header_path, cpp_path = self.output_paths_for_bindings(interface_name)
         return (
             (header_path, header_text),
             (cpp_path, cpp_text),
         )
 
     def generate_dictionary_code(self, definitions, dictionary_name,
-                                 dictionary):
+                                 dictionary, mode):
         interface_info = self.interfaces_info[dictionary_name]
-        bindings_results = self.generate_dictionary_bindings(
-            dictionary_name, interface_info, dictionary)
-        impl_results = self.generate_dictionary_impl(
-            dictionary_name, interface_info, dictionary)
-        return bindings_results + impl_results
+        results = set()
+        if (mode & MODE_BINDINGS) == MODE_BINDINGS:
+            results.update(self.generate_dictionary_bindings(
+                dictionary_name, interface_info, dictionary))
+        if (mode & MODE_DICTIONARY_IMPL) == MODE_DICTIONARY_IMPL:
+            results.update(self.generate_dictionary_impl(
+                dictionary_name, interface_info, dictionary))
+        return results
 
     def generate_dictionary_bindings(self, dictionary_name,
                                      interface_info, dictionary):
         header_template = self.jinja_env.get_template('dictionary_v8.h')
         cpp_template = self.jinja_env.get_template('dictionary_v8.cpp')
         template_context = v8_dictionary.dictionary_context(dictionary)
         # Add the include for interface itself
         template_context['header_includes'].add(interface_info['include_path'])
         header_text, cpp_text = render_template(
             interface_info, header_template, cpp_template, template_context)
         header_path, cpp_path = self.output_paths_for_bindings(dictionary_name)
         return (
             (header_path, header_text),
             (cpp_path, cpp_text),
         )
 
     def generate_dictionary_impl(self, dictionary_name,
                                  interface_info, dictionary):
         header_template = self.jinja_env.get_template('dictionary_impl.h')
         cpp_template = self.jinja_env.get_template('dictionary_impl.cpp')
         template_context = v8_dictionary.dictionary_impl_context(
             dictionary, self.interfaces_info)
         header_text, cpp_text = render_template(
             interface_info, header_template, cpp_template, template_context)
-        header_path, cpp_path = self.output_paths_for_impl(dictionary_name)
+        header_path, cpp_path = self.output_paths_for_impl(
+            dictionary_name, interface_info['relative_dir'])
         return (
             (header_path, header_text),
             (cpp_path, cpp_text),
         )
 
 
 def initialize_jinja_env(cache_dir):
     jinja_env = jinja2.Environment(
         loader=jinja2.FileSystemLoader(templates_dir),
         # Bytecode cache is not concurrency-safe unless pre-cached:
@@ skipping 52 matching lines @@
 
     # Create a dummy file as output for the build system,
     # since filenames of individual cache files are unpredictable and opaque
     # (they are hashes of the template path, which varies based on environment)
     with open(dummy_filename, 'w') as dummy_file:
         pass  # |open| creates or touches the file
 
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv))