IDL: Add build target for IDL dictionary impl generation in core

Source/bindings/scripts/code_generator_v8.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 77 matching lines @@
     template_context['header_includes'] = sorted(
         template_context['header_includes'])
     includes.update(interface_info.get('dependencies_include_paths', []))
     template_context['cpp_includes'] = sorted(includes)
 
     header_text = header_template.render(template_context)
     cpp_text = cpp_template.render(template_context)
     return header_text, cpp_text
 
 
-class CodeGeneratorV8(object):
+class CodeGeneratorBase(object):
+    """Base class for v8 bindings generator and IDL dictionary impl generator"""
+
     def __init__(self, interfaces_info, cache_dir, output_dir):
         interfaces_info = interfaces_info or {}
         self.interfaces_info = interfaces_info
         self.jinja_env = initialize_jinja_env(cache_dir)
         self.output_dir = output_dir
 
         # Set global type info
         idl_types.set_ancestors(dict(
             (interface_name, interface_info['ancestors'])
             for interface_name, interface_info in interfaces_info.iteritems()
@@ skipping 15 matching lines @@
             for interface_name, interface_info in interfaces_info.iteritems()
             if 'GarbageCollected' in interface_info['inherited_extended_attributes']))
         IdlType.set_will_be_garbage_collected_types(set(
             interface_name
             for interface_name, interface_info in interfaces_info.iteritems()
             if 'WillBeGarbageCollected' in interface_info['inherited_extended_attributes']))
         v8_types.set_component_dirs(dict(
             (interface_name, interface_info['component_dir'])
             for interface_name, interface_info in interfaces_info.iteritems()))
 
-    def output_paths_for_bindings(self, definition_name):
+    def generate_code(self, definitions, definition_name):
+        """Returns .h/.cpp code as ((path, content)...)."""
+        # Set local type info
+        IdlType.set_callback_functions(definitions.callback_functions.keys())
+        IdlType.set_enums((enum.name, enum.values)
+                          for enum in definitions.enumerations.values())
+        return self.generate_code_internal(definitions, definition_name)
+
+    def generate_code_internal(self, definitions, definition_name):
+        # This should be implemented in subclasses.
+        raise NotImplementedError()
+
+
+class CodeGeneratorV8(CodeGeneratorBase):
+    def __init__(self, interfaces_info, cache_dir, output_dir):
+        CodeGeneratorBase.__init__(self, interfaces_info, cache_dir, output_dir)
+
+    def output_paths(self, definition_name):
         header_path = posixpath.join(self.output_dir,
                                      'V8%s.h' % definition_name)
         cpp_path = posixpath.join(self.output_dir, 'V8%s.cpp' % definition_name)
         return header_path, cpp_path
 
-    def output_paths_for_impl(self, definition_name):
-        header_path = posixpath.join(self.output_dir, '%s.h' % definition_name)
-        cpp_path = posixpath.join(self.output_dir, '%s.cpp' % definition_name)
-        return header_path, cpp_path
-
-    def generate_code(self, definitions, definition_name):
-        """Returns .h/.cpp code as (header_text, cpp_text)."""
-        # Set local type info
-        IdlType.set_callback_functions(definitions.callback_functions.keys())
-        IdlType.set_enums((enum.name, enum.values)
-                          for enum in definitions.enumerations.values())
-
+    def generate_code_internal(self, definitions, definition_name):
         if definition_name in definitions.interfaces:
             return self.generate_interface_code(
                 definitions, definition_name,
                 definitions.interfaces[definition_name])
         if definition_name in definitions.dictionaries:
             return self.generate_dictionary_code(
                 definitions, definition_name,
                 definitions.dictionaries[definition_name])
         raise ValueError('%s is not in IDL definitions' % definition_name)
 
@@ skipping 13 matching lines @@
         header_template = self.jinja_env.get_template(header_template_filename)
         cpp_template = self.jinja_env.get_template(cpp_template_filename)
 
         interface_info = self.interfaces_info[interface_name]
 
         template_context = interface_context(interface)
         # Add the include for interface itself
         template_context['header_includes'].add(interface_info['include_path'])
         header_text, cpp_text = render_template(
             interface_info, header_template, cpp_template, template_context)
-        header_path, cpp_path = self.output_paths_for_bindings(interface_name)
+        header_path, cpp_path = self.output_paths(interface_name)
         return (
             (header_path, header_text),
             (cpp_path, cpp_text),
         )
 
     def generate_dictionary_code(self, definitions, dictionary_name,
                                  dictionary):
-        interface_info = self.interfaces_info[dictionary_name]
-        bindings_results = self.generate_dictionary_bindings(
-            dictionary_name, interface_info, dictionary)
-        impl_results = self.generate_dictionary_impl(
-            dictionary_name, interface_info, dictionary)
-        return bindings_results + impl_results
-
-    def generate_dictionary_bindings(self, dictionary_name,
-                                     interface_info, dictionary):
         header_template = self.jinja_env.get_template('dictionary_v8.h')
         cpp_template = self.jinja_env.get_template('dictionary_v8.cpp')
         template_context = v8_dictionary.dictionary_context(dictionary)
+        interface_info = self.interfaces_info[dictionary_name]
         # Add the include for interface itself
         template_context['header_includes'].add(interface_info['include_path'])
         header_text, cpp_text = render_template(
             interface_info, header_template, cpp_template, template_context)
-        header_path, cpp_path = self.output_paths_for_bindings(dictionary_name)
+        header_path, cpp_path = self.output_paths(dictionary_name)
         return (
             (header_path, header_text),
             (cpp_path, cpp_text),
         )
 
-    def generate_dictionary_impl(self, dictionary_name,
-                                 interface_info, dictionary):
+
+class CodeGeneratorDictionaryImpl(CodeGeneratorBase):
+    def __init__(self, interfaces_info, cache_dir, output_dir,
+                 use_relative_output_path=True):
+        CodeGeneratorBase.__init__(self, interfaces_info, cache_dir, output_dir)
+        self.use_relative_output_path = use_relative_output_path
+
+    def output_paths(self, definition_name, relative_dir):
+        if self.use_relative_output_path:
+            output_dir = posixpath.join(self.output_dir, relative_dir)
+        else:
+            output_dir = self.output_dir
+        header_path = posixpath.join(output_dir, '%s.h' % definition_name)
+        cpp_path = posixpath.join(output_dir, '%s.cpp' % definition_name)
+        return header_path, cpp_path
+
+    def generate_code_internal(self, definitions, definition_name):
+        if not definition_name in definitions.dictionaries:
+            raise ValueError('%s is not an IDL dictionary')
+        dictionary = definitions.dictionaries[definition_name]
+        interface_info = self.interfaces_info[definition_name]
         header_template = self.jinja_env.get_template('dictionary_impl.h')
         cpp_template = self.jinja_env.get_template('dictionary_impl.cpp')
         template_context = v8_dictionary.dictionary_impl_context(
             dictionary, self.interfaces_info)
         header_text, cpp_text = render_template(
             interface_info, header_template, cpp_template, template_context)
-        header_path, cpp_path = self.output_paths_for_impl(dictionary_name)
+        header_path, cpp_path = self.output_paths(
+            definition_name, interface_info['relative_dir'])
         return (
             (header_path, header_text),
             (cpp_path, cpp_text),
         )
 
 
 def initialize_jinja_env(cache_dir):
     jinja_env = jinja2.Environment(
         loader=jinja2.FileSystemLoader(templates_dir),
         # Bytecode cache is not concurrency-safe unless pre-cached:
@@ skipping 52 matching lines @@
 
     # Create a dummy file as output for the build system,
     # since filenames of individual cache files are unpredictable and opaque
     # (they are hashes of the template path, which varies based on environment)
     with open(dummy_filename, 'w') as dummy_file:
         pass  # |open| creates or touches the file
 
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv))