IDL: Add build target for IDL dictionary impl generation in core

Source/bindings/core/v8/generated.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Generate IDL bindings for core, plus aggregate bindings files.
 #
 # Design doc: http://www.chromium.org/developers/design-documents/idl-build
 
 {
   'includes': [
@@ skipping 25 matching lines @@
       # FIXME: should not depend on modules, but partial interface definitions
       # in modules change bindings for core http://crbug.com/358074
       '../../modules/generated.gyp:modules_global_constructors_idls',
       '<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
       '<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
       # FIXME: should be interfaces_info_core (w/o modules)
       # http://crbug.com/358074
       '../../modules/generated.gyp:interfaces_info',
     ],
     'sources': [
       '<@(core_interface_idl_files)',

[haraken, 2014/08/05 15:51:37]

These IDL files are already written in the 'sources' section, but they are
complied with our IDL compiler.

The only difference I can see between 'bindings_core_v8_generated_individual'
and 'bindings_core_dictionary_impl_generated' is that the former is using
'rules' whereas the latter is using 'actions'. Will the difference affect how
the 'sources' section is treated?

[Nico, 2014/08/05 17:49:03]

The code I linked to above apparently calls
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gyp/pylib/gy...
and early-outs if that returns true. So it looks gyp's build-in idl rules on
Windows aren't added if there's a .idl rule on the target, but it does not check
for a .idl action.

     ],
     'rules': [{
       'rule_name': 'binding',
       'extension': 'idl',
       'msvs_external_rule': 1,
       'inputs': [
         '<@(idl_lexer_parser_files)',  # to be explicit (covered by parsetab)
         '<@(idl_compiler_files)',
         '<(bindings_scripts_output_dir)/lextab.py',
         '<(bindings_scripts_output_dir)/parsetab.pickle',
@@ skipping 58 matching lines @@
         'core',
         '<(core_idl_files_list)',
         '--',
         '<@(bindings_core_v8_generated_aggregate_files)',
       ],
       'message': 'Generating aggregate generated core V8 bindings files',
     }],
   },
 ################################################################################
   {
+    # GN version: //third_party/WebKit/Source/bindings/core/v8:bindings_core_dictionary_impl_generated
+    # http://crbug.com/358074; See comments on
+    # 'bindings_core_v8_generated_individual' target
+    'target_name': 'bindings_core_dictionary_impl_generated',
+    'type': 'none',
+    'hard_dependency': 1,
+    'dependencies': [
+      '<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
+      '<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
+      '../../modules/generated.gyp:interfaces_info',
+    ],
+    'sources': [
+      # FIXME: Add '<@(core_dictionary_idl_files)',
+      '<@(core_testing_dictionary_idl_files)',
+    ],
+    'actions': [{
+      'action_name': 'idl_dictionary',
+      'inputs': [
+        '<@(core_testing_dictionary_idl_files)',
+        '<@(idl_lexer_parser_files)',
+        '<@(idl_compiler_files)',
+        '<(bindings_scripts_output_dir)/lextab.py',
+        '<(bindings_scripts_output_dir)/parsetab.pickle',
+        '<(bindings_scripts_output_dir)/cached_jinja_templates.stamp',
+        '<(bindings_dir)/IDLExtendedAttributes.txt',
+        '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+      ],
+      'outputs': [
+        # FIXME: Add '<@(generated_core_dictionary_files)',
+        '<@(generated_core_testing_dictionary_files)',
+      ],
+      'action': [
+        'python',
+        '<(bindings_scripts_dir)/idl_compiler.py',
+        '--cache-dir',
+        '<(bindings_scripts_output_dir)',
+        '--output-dir',
+        '<(SHARED_INTERMEDIATE_DIR)/blink/',
+        '--interfaces-info',
+        '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+        '--write-file-only-if-changed',
+        '<(write_file_only_if_changed)',
+        '--generate-dictionary-impl',
+        '<(core_dictionary_idl_files_list)',
+      ],
+      'message': 'Generating core IDL dictionary impl classes',
+    }],
+  },
+################################################################################
+  {
     # GN version: //third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated
     'target_name': 'bindings_core_v8_generated',
     'type': 'none',
     'dependencies': [
+      'bindings_core_dictionary_impl_generated',
       'bindings_core_v8_generated_aggregate',
       'bindings_core_v8_generated_individual',
     ],
   },
 ################################################################################
   ],  # targets
 }