Extract Builder and subclasses to separate module.

Extract Builder and subclasses to separate module.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290037

[qyearsley, 2014-07-30 01:49:45]

https://codereview.chromium.org/429763003/diff/1/tools/auto_bisect/bisect_uti...
File tools/auto_bisect/bisect_utils.py (right):

https://codereview.chromium.org/429763003/diff/1/tools/auto_bisect/bisect_uti...
tools/auto_bisect/bisect_utils.py:71: # Paths to CrOS-related files, relative to
...
What are these paths relative to? Where is cros/chromite/... etc.? I believe
that these paths should be relative to the directory where
bisect-perf-regression.py is run from, and that these don't need to be changed,
but I'm not 100% sure.

[qyearsley, 2014-08-15 17:34:48]

On 2014/07/30 01:49:45, qyearsley wrote:
>
https://codereview.chromium.org/429763003/diff/1/tools/auto_bisect/bisect_uti...
> File tools/auto_bisect/bisect_utils.py (right):
> 
>
https://codereview.chromium.org/429763003/diff/1/tools/auto_bisect/bisect_uti...
> tools/auto_bisect/bisect_utils.py:71: # Paths to CrOS-related files, relative
to
> ...
> What are these paths relative to? Where is cros/chromite/... etc.? I believe
> that these paths should be relative to the directory where
> bisect-perf-regression.py is run from, and that these don't need to be
changed,
> but I'm not 100% sure.

Friendly ping

[prasadv, 2014-08-15 17:49:36]

lgtm

https://codereview.chromium.org/429763003/diff/1/tools/auto_bisect/bisect_uti...
File tools/auto_bisect/bisect_utils.py (right):

https://codereview.chromium.org/429763003/diff/1/tools/auto_bisect/bisect_uti...
tools/auto_bisect/bisect_utils.py:71: # Paths to CrOS-related files, relative to
...
On 2014/07/30 01:49:45, qyearsley wrote:
> What are these paths relative to? Where is cros/chromite/... etc.? I believe
> that these paths should be relative to the directory where
> bisect-perf-regression.py is run from, and that these don't need to be
changed,
> but I'm not 100% sure.
I'm not sure about either, I believe we've functionality to bisect CrOS, but no
one ever tried it.

[qyearsley, 2014-08-15 18:51:20]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-08-15 18:58:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qyearsley@chromium.org/429763003/40001

[commit-bot: I haz the power, 2014-08-15 22:59:12]

Committed patchset #3 (40001) as 290037