Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/test/data/extensions/api_test/extension_options/embed_other/embedder/manifest.json

Issue 429763002: Implement createfailed event for <extensionoptions> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove console.logs and diff from CL 412093002 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/extension_options/embed_other/embedder/manifest.json
diff --git a/chrome/test/data/extensions/api_test/browser_action/none/manifest.json b/chrome/test/data/extensions/api_test/extension_options/embed_other/embedder/manifest.json
similarity index 50%
copy from chrome/test/data/extensions/api_test/browser_action/none/manifest.json
copy to chrome/test/data/extensions/api_test/extension_options/embed_other/embedder/manifest.json
index 707795e73751bbe795add486bbbfefaac199253f..11e34a99c1107b6006fa6a82ffd0338d12ce0015 100644
--- a/chrome/test/data/extensions/api_test/browser_action/none/manifest.json
+++ b/chrome/test/data/extensions/api_test/extension_options/embed_other/embedder/manifest.json
@@ -1,11 +1,12 @@
{
- "name": "An extension with no browser action",
- "version": "1.0",
+ "name": "embed_other_test_embedder",
+ "version": "0.1",
"manifest_version": 2,
"background": {
"page": "background.html"
not at google - send to devlin 2014/08/04 19:12:03 I'd say "likewise" but background.js doesn't actua
ericzeng 2014/08/04 21:15:34 This is kind of a hack so that the embedded extens
not at google - send to devlin 2014/08/04 21:16:48 Ok cool. Add a comment then.
ericzeng 2014/08/04 21:32:22 Done.
},
"permissions": [
- "tabs", "http://*/*"
+ "embeddedExtensionOptions",
+ "storage"
]
}

Powered by Google App Engine
This is Rietveld 408576698