Implement createfailed event for <extensionoptions>

chrome/renderer/resources/extensions/extension_options.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var DocumentNatives = requireNative('document_natives');
 var ExtensionOptionsEvents =
     require('extensionOptionsEvents').ExtensionOptionsEvents;
 var GuestViewInternal =
     require('binding').Binding.create('guestViewInternal').generate();
 var IdGenerator = requireNative('id_generator');
 var utils = require('utils');
 
 // Mapping of the autosize attribute names to default values
 var AUTO_SIZE_ATTRIBUTES = {
   'autosize': 'on',
   'maxheight': 600,
   'maxwidth': 800,
   'minheight': 32,
   'minwidth': 80
 };
 
 function ExtensionOptionsInternal(extensionoptionsNode) {
   privates(extensionoptionsNode).internal = this;
   this.extensionoptionsNode = extensionoptionsNode;
   this.viewInstanceId = IdGenerator.GetNextId();
 
   // on* Event handlers.
   this.eventHandlers = {};
+
+  // setupEventProperty is normally called in extension_options_events.js to
+  // register events, but the createfailed event is registered here because
+  // the event is fired from here instead of through
+  // extension_options_events.js.
+  this.setupEventProperty('createfailed');
+
   new ExtensionOptionsEvents(this, this.viewInstanceId);
 
   this.setupNodeProperties();
 
   if (this.parseExtensionAttribute())
     this.init();
 };
 
 ExtensionOptionsInternal.prototype.attachWindow = function(instanceId) {
   this.instanceId = instanceId;
@@ skipping 16 matching lines @@
 
 ExtensionOptionsInternal.prototype.createGuest = function() {
   var params = {
     'extensionId': this.extensionId,
   };
   GuestViewInternal.createGuest(
       'extensionoptions',
       params,
       function(instanceId) {
         if (instanceId == 0) {
+          // Fire a createfailed event here rather than in ExtensionOptionsGuest
+          // because the guest will not be created, and cannot fire an event.
           this.initCalled = false;
+          var createFailedEvent = new Event('createfailed', { bubbles: true });
+          this.dispatchEvent(createFailedEvent);
         } else {
           this.attachWindow(instanceId);
           GuestViewInternal.setAutoSize(this.instanceId, {
             'enableAutoSize':
                 this.extensionoptionsNode.hasAttribute('autosize'),
             'min': {
             'width': parseInt(this.minwidth || 0),
             'height': parseInt(this.minheight || 0)
           },
             'max': {
@@ skipping 59 matching lines @@
   this.createGuest();
 };
 
 ExtensionOptionsInternal.prototype.onSizeChanged = function(width, height) {
   this.browserPluginNode.style.width = width + 'px';
   this.browserPluginNode.style.height = height + 'px';
 };
 
 ExtensionOptionsInternal.prototype.parseExtensionAttribute = function() {
   if (this.extensionoptionsNode.hasAttribute('extension')) {
-    var extensionId = this.extensionoptionsNode.getAttribute('extension');
-    // Only allow extensions to embed their own options page (if it has one).
-    if (chrome.runtime.id == extensionId &&
-        chrome.runtime.getManifest().hasOwnProperty('options_page')) {
-      this.extensionId  = extensionId;
-      return true;
-    }
+    this.extensionId = this.extensionoptionsNode.getAttribute('extension');
+    return true;
   }
   return false;
 };
 
 // Adds an 'on<event>' property on the view, which can be used to set/unset
 // an event handler.
 ExtensionOptionsInternal.prototype.setupEventProperty = function(eventName) {
   var propertyName = 'on' + eventName.toLowerCase();
-  var self = this;
   var extensionoptionsNode = this.extensionoptionsNode;
   Object.defineProperty(extensionoptionsNode, propertyName, {
     get: function() {
-      return self.eventHandlers[propertyName];
-    },
+      return this.eventHandlers[propertyName];
+    }.bind(this),
     set: function(value) {
-      if (self.eventHandlers[propertyName])
+      if (this.eventHandlers[propertyName])
         extensionoptionsNode.removeEventListener(
-            eventName, self.eventHandlers[propertyName]);
-      self.eventHandlers[propertyName] = value;
+            eventName, this.eventHandlers[propertyName]);
+      this.eventHandlers[propertyName] = value;
       if (value)
         extensionoptionsNode.addEventListener(eventName, value);
-    },
+    }.bind(this),
     enumerable: true
   });
 };
 
 ExtensionOptionsInternal.prototype.setupNodeProperties = function() {
   utils.forEach(AUTO_SIZE_ATTRIBUTES, function(attributeName) {
     // Get the size constraints from the <extensionoptions> tag, or use the
     // defaults if not specified
     if (this.extensionoptionsNode.hasAttribute(attributeName)) {
       this[attributeName] =
@@ skipping 87 matching lines @@
 
 var useCapture = true;
 window.addEventListener('readystatechange', function listener(event) {
   if (document.readyState == 'loading')
     return;
 
   registerBrowserPluginElement();
   registerExtensionOptionsElement();
   window.removeEventListener(event.type, listener, useCapture);
 }, useCapture);