Implement createfailed event for <extensionoptions>

chrome/browser/guest_view/extension_options/extension_options_apitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/files/file_path.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/switches.h"
 
 using extensions::Extension;
 using extensions::FeatureSwitch;
 
 class ExtensionOptionsApiTest : public ExtensionApiTest {
  private:
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     // Need to add a command line flag as well as a FeatureSwitch because the
     // FeatureSwitch is not copied over to the renderer process from the
     // browser process.
     command_line->AppendSwitch(
         extensions::switches::kEnableEmbeddedExtensionOptions);
     ExtensionApiTest::SetUpCommandLine(command_line);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(ExtensionOptionsApiTest, ExtensionCanEmbedOwnOptions) {
   FeatureSwitch::ScopedOverride enable_options(
       FeatureSwitch::embedded_extension_options(), true);
 
   const Extension* extension = InstallExtension(
       test_data_dir_.AppendASCII("extension_options").AppendASCII("embed_self"),
       1);
   ASSERT_TRUE(extension);
   ASSERT_TRUE(RunExtensionSubtest("extension_options/embed_self", "test.html"));
 }
+
+IN_PROC_BROWSER_TEST_F(ExtensionOptionsApiTest,
+                       ShouldNotEmbedOtherExtensionsOptions) {
+  FeatureSwitch::ScopedOverride enable_options(

[not at google - send to devlin, 2014/07/30 17:33:10]

you might as well make the feature switch a scoped_ptr<> private member of the
ExtensionOptionsApiTest, initialized in SetUpCommandLine, so you don't need to
spell it out all the time.

[ericzeng, 2014/08/01 17:13:26]

Done.

+      FeatureSwitch::embedded_extension_options(), true);
+  base::FilePath dir = test_data_dir_.AppendASCII("extension_options")
+                           .AppendASCII("embed_other");
+
+  const Extension* embedder = InstallExtension(dir.AppendASCII("embedder"), 1);
+  const Extension* embedded = InstallExtension(dir.AppendASCII("embedded"), 1);

[not at google - send to devlin, 2014/07/30 17:33:10]

you don't actually use |embedder| or |embedded| so you can do

ASSERT_TRUE(InstallExtenssion(dir.AppendASCII("embedder"), 1)

etc.

[ericzeng, 2014/08/01 17:13:26]

Done.

+
+  ASSERT_TRUE(embedder);
+  ASSERT_TRUE(embedded);
+
+  ASSERT_TRUE(RunExtensionSubtest("extension_options/embed_other/embedder",
+                                  "test.html"));
+}