base/time/time.h - Issue 429743002: Make QPCValueToMicroseconds faster in case the value is less than 44 bits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/time/time.h

Issue 429743002: Make QPCValueToMicroseconds faster in case the value is less than 44 bits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Typo Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/time/time.h

diff --git a/base/time/time.h b/base/time/time.h

index 41d662afa6a908a513d90acaed56d58eaa58d54e..56a1a8dac6ab5e4538bd16c87370ad5e91b229bc 100644

--- a/base/time/time.h

+++ b/base/time/time.h

@@ -230,6 +230,11 @@ class BASE_EXPORT Time {

// this global header and put in the platform-specific ones when we remove the

// migration code.

static const int64 kWindowsEpochDeltaMicroseconds;

+#else

+ // To avoid overflow in QPC to Microseconds calculations, since we multiplying

willchan no longer on Chromium 2014/08/01 22:41:55 grammar error at the end of the line. perhaps s/we

fmeawad 2014/08/05 22:20:09 Done.

+ // by kMicrosecondsPerSecond, then the QPC value should not exceed

+ // (2^63 - 1) / 1E6. If it exceeds that threshold, we divide then multiply.

+ static const int64 kQPCOverflowThreshold = 0x8637BD05AF7;

#endif

// Represents an exploded time that can be formatted nicely. This is kind of

« no previous file with comments | « no previous file | base/time/time_win.cc » ('j') | base/time/time_win_unittest.cc » ('J')