Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 429723006: Add comment about CaretBase::updateCaretRect. (Closed)

Created:
6 years, 4 months ago by yoichio
Modified:
6 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add comment about CaretBase::updateCaretRect. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179193

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/editing/Caret.h View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
yoichio
6 years, 4 months ago (2014-07-30 01:11:02 UTC) #1
tkent
lgtm https://codereview.chromium.org/429723006/diff/1/Source/core/editing/Caret.h File Source/core/editing/Caret.h (right): https://codereview.chromium.org/429723006/diff/1/Source/core/editing/Caret.h#newcode53 Source/core/editing/Caret.h:53: // A position in HTMLTextFromControlElement is a typically ...
6 years, 4 months ago (2014-07-30 01:25:07 UTC) #2
yoichio
https://codereview.chromium.org/429723006/diff/1/Source/core/editing/Caret.h File Source/core/editing/Caret.h (right): https://codereview.chromium.org/429723006/diff/1/Source/core/editing/Caret.h#newcode53 Source/core/editing/Caret.h:53: // A position in HTMLTextFromControlElement is a typically example. ...
6 years, 4 months ago (2014-07-30 01:27:39 UTC) #3
yoichio
The CQ bit was checked by yoichio@chromium.org
6 years, 4 months ago (2014-07-30 01:27:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/429723006/20001
6 years, 4 months ago (2014-07-30 01:28:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-30 02:50:28 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 03:13:12 UTC) #7
Message was sent while issue was closed.
Change committed as 179193

Powered by Google App Engine
This is Rietveld 408576698