chrome/common/extensions/docs/server2/redirector.py - Issue 429723005: Docserver: Only fetch content versions in the crons, not their contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/redirector.py

Issue 429723005: Docserver: Only fetch content versions in the crons, not their contents. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/cron.yaml ('k') | chrome/common/extensions/docs/server2/template_data_source.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/redirector.py

diff --git a/chrome/common/extensions/docs/server2/redirector.py b/chrome/common/extensions/docs/server2/redirector.py

index 89053311143ed30305dba9fa04ceba4baa904e97..c97964d10c3fd5a00383e2be67ad2a1ffdf10bfc 100644

--- a/chrome/common/extensions/docs/server2/redirector.py

+++ b/chrome/common/extensions/docs/server2/redirector.py

@@ -6,7 +6,7 @@ import posixpath

from urlparse import urlsplit

from file_system import FileNotFoundError

-from future import Future

+from future import All

from path_util import Segment, Join, SplitParent

class Redirector(object):

@@ -108,6 +108,5 @@ class Redirector(object):

futures = []

for root, dirs, files in self._file_system.Walk(''):

if 'redirects.json' in files:

- futures.append(

- self._cache.GetFromFile(posixpath.join(root, 'redirects.json')))

- return Future(callback=lambda: [f.Get() for f in futures])

+ futures.append(self._cache.GetFromFile(Join(root, 'redirects.json')))

+ return All(futures)

« no previous file with comments | « chrome/common/extensions/docs/server2/cron.yaml ('k') | chrome/common/extensions/docs/server2/template_data_source.py » ('j') | no next file with comments »