Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 429723002: Run pkg-config for Udev only if use_udev==1 (Closed)

Created:
6 years, 4 months ago by dnicoara
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Run pkg-config for Udev only if use_udev==1 Some embedded platforms do not have udev support. The change will skip running pkg-config if use_udev=0. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dnicoara
PTAL
6 years, 4 months ago (2014-08-08 14:40:45 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-11 16:37:11 UTC) #2
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 4 months ago (2014-08-11 17:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/429723002/1
6 years, 4 months ago (2014-08-11 17:25:13 UTC) #4
commit-bot: I haz the power
Change committed as 288770
6 years, 4 months ago (2014-08-11 19:49:36 UTC) #5
dnicoara
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/469763002/ by dnicoara@chromium.org. The ...
6 years, 4 months ago (2014-08-13 13:44:03 UTC) #6
brettw
There's also //device/udev_linux. I don't really know what that is but a bunch of targets ...
6 years, 4 months ago (2014-08-13 20:37:48 UTC) #7
dnicoara
6 years, 4 months ago (2014-08-13 21:03:57 UTC) #8
Message was sent while issue was closed.
On 2014/08/13 20:37:48, brettw wrote:
> There's also //device/udev_linux. I don't really know what that is but a bunch
> of targets link to it. It might be nice to move the udev pkg_config rule
there.
> The only reason this might be bad is it the udev config would be used by some
> ChromeOS components that would see //build but not //device

There are a couple different places that include the udev target directly. I
haven't followed all the dependencies but it gets hairy once you'd take into
account the unittests targets.

spang@ was nice and started updating all the places to perform a check against
use_udev==0  (https://codereview.chromium.org/467983002/)

Powered by Google App Engine
This is Rietveld 408576698