Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chrome/test/chromedriver/capabilities.h

Issue 429693003: [ChromeDriver] Implementing PerfLoggingPrefs for perf log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing memory leak Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/capabilities.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.h
diff --git a/chrome/test/chromedriver/capabilities.h b/chrome/test/chromedriver/capabilities.h
index edef9baeac599ce7285771b811219153ffc632c6..b521e444296bf8b5bdb6998202280b41d4492f30 100644
--- a/chrome/test/chromedriver/capabilities.h
+++ b/chrome/test/chromedriver/capabilities.h
@@ -60,6 +60,27 @@ class Switches {
typedef std::map<std::string, Log::Level> LoggingPrefs;
+struct PerfLoggingPrefs {
+ PerfLoggingPrefs();
+ ~PerfLoggingPrefs();
+
+ // We must distinguish between a log domain being set by default and being
+ // explicitly set. Otherwise, |PerformanceLogger| could only handle 3 of 4
+ // possible combinations (tracing enabled/disabled + Timeline on/off).
+ enum InspectorDomainStatus {
+ kDefaultEnabled,
+ kDefaultDisabled,
+ kExplicitlyEnabled,
+ kExplicitlyDisabled
+ };
+
+ InspectorDomainStatus network;
+ InspectorDomainStatus page;
+ InspectorDomainStatus timeline;
+
+ std::string trace_categories; // Non-empty string enables tracing.
+};
+
struct Capabilities {
Capabilities();
~Capabilities();
@@ -114,6 +135,8 @@ struct Capabilities {
// If set, enable minidump for chrome crashes and save to this directory.
std::string minidump_path;
+ PerfLoggingPrefs perf_logging_prefs;
+
scoped_ptr<base::DictionaryValue> prefs;
Switches switches;
« no previous file with comments | « no previous file | chrome/test/chromedriver/capabilities.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698