Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10439)

Unified Diff: chrome/test/chromedriver/performance_logger.h

Issue 429693003: [ChromeDriver] Implementing PerfLoggingPrefs for perf log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Increasing test coverage Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/performance_logger.h
diff --git a/chrome/test/chromedriver/performance_logger.h b/chrome/test/chromedriver/performance_logger.h
index b96f4904ff8d575b8363bd0c31250f163f807134..df24108b9bf3fd86239e5b9605e3f8626e12233f 100644
--- a/chrome/test/chromedriver/performance_logger.h
+++ b/chrome/test/chromedriver/performance_logger.h
@@ -5,8 +5,11 @@
#ifndef CHROME_TEST_CHROMEDRIVER_PERFORMANCE_LOGGER_H_
#define CHROME_TEST_CHROMEDRIVER_PERFORMANCE_LOGGER_H_
+#include <string>
+
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "chrome/test/chromedriver/capabilities.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/command_listener.h"
@@ -21,10 +24,13 @@ class Log;
// }
class PerformanceLogger : public DevToolsEventListener, public CommandListener {
public:
- // Creates a PerformanceLogger that creates entries in the given Log object.
- // The log is owned elsewhere and must not be null.
+ // Creates a |PerformanceLogger| with default preferences that creates entries
+ // in the given Log object. The log is owned elsewhere and must not be null.
explicit PerformanceLogger(Log* log);
+ // Creates a |PerformanceLogger| with specific preferences.
+ explicit PerformanceLogger(Log* log, const PerfLoggingPrefs& prefs);
samuong 2014/08/04 06:08:22 don't need to make this explicit
johnmoore 2014/08/04 17:37:58 Done.
+
// Enables Page,Network,Timeline events for client, which must not be null.
virtual Status OnConnected(DevToolsClient* client) OVERRIDE;
// Translates an event into a log entry.
@@ -39,6 +45,7 @@ class PerformanceLogger : public DevToolsEventListener, public CommandListener {
private:
Log* log_; // The log where to create entries.
+ PerfLoggingPrefs prefs_;
DISALLOW_COPY_AND_ASSIGN(PerformanceLogger);
};

Powered by Google App Engine
This is Rietveld 408576698