[Android] Pass the right listener to DatePickerDialog

[Android] Pass the right listener to DatePickerDialog

BUG=395768
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286791

[aurimas (slooooooooow), 2014-07-30 18:27:04]

lgtm

https://codereview.chromium.org/429633003/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/429633003/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:300: //
TODO(miguelg) use the finalcode for the L
Can you attach a bug number to the TODO?

[Miguel Garcia, 2014-07-31 08:21:42]

https://codereview.chromium.org/429633003/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/429633003/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:300: //
TODO(miguelg) use the finalcode for the L
On 2014/07/30 18:27:03, aurimas wrote:
> Can you attach a bug number to the TODO?

Done.

[Miguel Garcia, 2014-07-31 08:21:49]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2014-07-31 08:23:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miguelg@chromium.org/429633003/60001

[commit-bot: I haz the power, 2014-07-31 10:02:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Miguel Garcia, 2014-07-31 10:05:58]

+rmcilroy for OWNERS approval

[commit-bot: I haz the power, 2014-07-31 10:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 10:06:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rmcilroy, 2014-07-31 10:19:59]

lgtm once sdk check is changed.

https://codereview.chromium.org/429633003/diff/60001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right):

https://codereview.chromium.org/429633003/diff/60001/base/android/java/src/or...
base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:302: return
Build.VERSION.SDK_INT <  20; /* CUR_DEVELOPMENT */
I think the way to do this for unreleased versions is:
"L".equals(Build.VERSION.CODENAME);
otherwise this will also trigger on API 20, which is not the API version which L
will release with.

[Miguel Garcia, 2014-07-31 11:13:41]

On 2014/07/31 10:19:59, rmcilroy wrote:
> lgtm once sdk check is changed.
> 
>
https://codereview.chromium.org/429633003/diff/60001/base/android/java/src/or...
> File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
(right):
> 
>
https://codereview.chromium.org/429633003/diff/60001/base/android/java/src/or...
> base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:302: return
> Build.VERSION.SDK_INT <  20; /* CUR_DEVELOPMENT */
> I think the way to do this for unreleased versions is:
> "L".equals(Build.VERSION.CODENAME);
> otherwise this will also trigger on API 20, which is not the API version which
L
> will release with.

We discussed some pros and cons and decided to keep it like this until we can
actually change it to the right version.

[Miguel Garcia, 2014-07-31 11:13:47]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2014-07-31 11:15:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miguelg@chromium.org/429633003/60001

[commit-bot: I haz the power, 2014-07-31 13:26:00]

Change committed as 286791