Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 429603003: Check for negative zero in floor when compiling with MSVC. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Check for negative zero in floor when compiling with MSVC. R=danno@chromium.org BUG=v8:3477 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M src/utils.h View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 4 months ago (2014-07-29 14:15:33 UTC) #1
danno
lgtm
6 years, 4 months ago (2014-07-29 14:17:14 UTC) #2
Yang
6 years, 4 months ago (2014-07-29 14:20:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698