Issue 429593006: DevTools: Do not re-create CSSWorkspaceBinding TargetInfo on MainFrameNavigated

Issue 429593006: DevTools: Do not re-create CSSWorkspaceBinding TargetInfo on MainFrameNavigated (Closed)

Created:
6 years, 4 months ago by apavlov

Modified:
6 years, 4 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Do not re-create CSSWorkspaceBinding TargetInfo on MainFrameNavigated R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179168

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert _dispose() #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	Source/devtools/front_end/sdk/CSSWorkspaceBinding.js	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/429593006/diff/1/Source/devtools/front_end/sdk/CSSWorkspaceBinding.js File Source/devtools/front_end/sdk/CSSWorkspaceBinding.js (left): https://chromiumcodereview.appspot.com/429593006/diff/1/Source/devtools/front_end/sdk/CSSWorkspaceBinding.js#oldcode32 Source/devtools/front_end/sdk/CSSWorkspaceBinding.js:32: this._targetToTargetInfo.remove(target)._dispose(); Let's keep it here.

6 years, 4 months ago (2014-07-29 16:48:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/429593006/20001

6 years, 4 months ago (2014-07-29 16:52:38 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-07-29 18:03:24 UTC) #5

Message was sent while issue was closed.

Change committed as 179168

Expand Messages | Collapse Messages