Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 429593005: Fix a few more warnings in chromium_code mode. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix a few more warnings in chromium_code mode. No intended behavior change. - Remove more unused variables, functions, member variables. - Put a few constructor initializers in the order they execute in. - Add braces for subobject initializers. - Fix a handful of signed / unsigned comparisons. BUG=pdfium:29 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/6c55495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -141 lines) Patch
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_utility.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 4 chunks +0 lines, -5 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_GlobalData.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 chunk +14 lines, -13 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 chunk +17 lines, -17 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 4 months ago (2014-07-29 16:51:18 UTC) #1
Bo Xu
On 2014/07/29 16:51:18, Nico (away) wrote: lgtm
6 years, 4 months ago (2014-07-29 17:06:03 UTC) #2
Nico
6 years, 4 months ago (2014-07-29 17:13:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r6c55495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698