src/ic.cc - Issue 429543004: Only generate a single normal IC per kind per slow-mode map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 429543004: Only generate a single normal IC per kind per slow-mode map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Port comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 23cae194a2112f116329daa13df237df731e3888..c11f58244e05b2299d61280f5fa0044d98a6c8ff 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -724,7 +724,7 @@ Handle<HeapType> IC::MapToType<HeapType>(Handle<Map> map, Isolate* region);

void IC::UpdateMonomorphicIC(Handle<Code> handler, Handle<String> name) {

- if (!handler->is_handler()) return set_target(*handler);

+ ASSERT(handler->is_handler());

Handle<Code> ic = PropertyICCompiler::ComputeMonomorphic(

kind(), name, receiver_type(), handler, extra_ic_state());

set_target(*ic);

« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »