Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 429493002: DevTools: DataGrid: autosize filler when rows fit viewport. (Closed)

Created:
6 years, 4 months ago by eustas
Modified:
6 years, 4 months ago
Reviewers:
vsevik, lushnikov, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: DataGrid: autosize filler when rows fit viewport. BUG=398332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179141

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/devtools/front_end/ui/DataGrid.js View 2 chunks +5 lines, -2 lines 4 comments Download

Messages

Total messages: 9 (0 generated)
eustas
6 years, 4 months ago (2014-07-29 08:29:25 UTC) #1
vsevik
lgtm https://codereview.chromium.org/429493002/diff/1/Source/devtools/front_end/ui/DataGrid.js File Source/devtools/front_end/ui/DataGrid.js (right): https://codereview.chromium.org/429493002/diff/1/Source/devtools/front_end/ui/DataGrid.js#newcode217 Source/devtools/front_end/ui/DataGrid.js:217: if (top || bottom) I think "if (bottom)" ...
6 years, 4 months ago (2014-07-29 08:51:45 UTC) #2
yurys
lgtm
6 years, 4 months ago (2014-07-29 08:51:48 UTC) #3
vsevik
https://codereview.chromium.org/429493002/diff/1/Source/devtools/front_end/ui/DataGrid.js File Source/devtools/front_end/ui/DataGrid.js (right): https://codereview.chromium.org/429493002/diff/1/Source/devtools/front_end/ui/DataGrid.js#newcode220 Source/devtools/front_end/ui/DataGrid.js:220: this._bottomFillerRow.style.height = "auto"; Is it guaranteed that the bottom ...
6 years, 4 months ago (2014-07-29 08:52:17 UTC) #4
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-07-29 10:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/429493002/1
6 years, 4 months ago (2014-07-29 11:00:14 UTC) #6
eustas
https://codereview.chromium.org/429493002/diff/1/Source/devtools/front_end/ui/DataGrid.js File Source/devtools/front_end/ui/DataGrid.js (right): https://codereview.chromium.org/429493002/diff/1/Source/devtools/front_end/ui/DataGrid.js#newcode217 Source/devtools/front_end/ui/DataGrid.js:217: if (top || bottom) On 2014/07/29 08:51:45, vsevik wrote: ...
6 years, 4 months ago (2014-07-29 11:00:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 12:09:53 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 12:42:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 179141

Powered by Google App Engine
This is Rietveld 408576698