Issue 429483004: Remove unused CPDFSDK_Annot::ResetAppearance().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429483004: Remove unused CPDFSDK_Annot::ResetAppearance(). (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Bo Xu

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Remove CPDFSDK_Annot::ResetAppearance(). It's unused, and it caused a warning about CPDFSDK_Widget::ResetAppearance() failing to override it (since these two unrelated methods had the same name). No intended behavior change. BUG=pdfium:29 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/c2df91c

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	fpdfsdk/include/fsdk_baseannot.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	fpdfsdk/src/fsdk_baseannot.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bo Xu

On 2014/07/31 02:56:33, Nico (away) wrote: > rietveld keeps suggesting bo_xu@chromium :-/ Just curious, can ...

6 years, 4 months ago (2014-07-31 16:42:06 UTC) #3

Nico

On 2014/07/31 16:42:06, Bo Xu wrote: > On 2014/07/31 02:56:33, Nico (away) wrote: > > ...

6 years, 4 months ago (2014-07-31 16:59:12 UTC) #4

Nico

6 years, 4 months ago (2014-07-31 17:00:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as rc2df91c (presubmit successful).

Expand Messages | Collapse Messages