Source/bindings/core/v8/WorkerScriptController.cpp - Issue 429453010: Drop V8RecursionScope dependency on ExecutionContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 429453010: Drop V8RecursionScope dependency on ExecutionContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reorder cleanup methods per haraken Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp

index 8ebafdfe1fcc773312a944b369fbc9062c7cc352..1a38509dba3e7e7c5e612a1eaf96d50bd7757e50 100644

--- a/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -130,7 +130,7 @@ public:

virtual void postCleanup()

{

- V8PerIsolateData::dispose(m_isolate);

+ V8PerIsolateData::destroy(m_isolate);

}

private:

@@ -153,6 +153,8 @@ WorkerScriptController::~WorkerScriptController()

if (isContextInitialized())

m_scriptState->disposePerContextData();

+ V8PerIsolateData::willBeDestroyed(m_isolate);

ThreadState::current()->addCleanupTask(IsolateCleanupTask::create(m_isolate));

}