Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 429453010: Drop V8RecursionScope dependency on ExecutionContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp
index 8ebafdfe1fcc773312a944b369fbc9062c7cc352..c82bcd45152f446f33e1aa047335e94b42fd30af 100644
--- a/Source/bindings/core/v8/WorkerScriptController.cpp
+++ b/Source/bindings/core/v8/WorkerScriptController.cpp
@@ -130,7 +130,7 @@ public:
virtual void postCleanup()
{
- V8PerIsolateData::dispose(m_isolate);
+ V8PerIsolateData::destroy(m_isolate);
}
private:
@@ -150,6 +150,8 @@ WorkerScriptController::~WorkerScriptController()
// See http://webkit.org/b/83104#c14 for why this is here.
blink::Platform::current()->didStopWorkerRunLoop(blink::WebWorkerRunLoop(m_workerGlobalScope.thread()));
+ V8PerIsolateData::willBeDestroyed(m_isolate);
haraken 2014/09/11 23:21:18 Nit: I'd put this after line 156. Conceptually Per
jsbell 2014/09/12 23:27:48 Done.
+
if (isContextInitialized())
m_scriptState->disposePerContextData();
« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | Source/bindings/modules/v8/ModuleBindingsInitializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698