Source/modules/indexeddb/IDBTransactionTest.cpp - Issue 429453010: Drop V8RecursionScope dependency on ExecutionContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 429453010: Drop V8RecursionScope dependency on ExecutionContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Factor out microtask fix/tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/indexeddb/IDBTransactionTest.cpp

diff --git a/Source/modules/indexeddb/IDBTransactionTest.cpp b/Source/modules/indexeddb/IDBTransactionTest.cpp

index 0235329ca762eb30202a7293a41045fd3336dd6c..133f621ab6eb9a9f77e2acbf718e83bfcc027429 100644

--- a/Source/modules/indexeddb/IDBTransactionTest.cpp

+++ b/Source/modules/indexeddb/IDBTransactionTest.cpp

@@ -105,7 +105,7 @@ TEST_F(IDBTransactionTest, EnsureLifetime)

EXPECT_EQ(1u, set.size());

Persistent<IDBRequest> request = IDBRequest::create(scriptState(), IDBAny::createUndefined(), transaction.get());

- IDBPendingTransactionMonitor::from(*executionContext()).deactivateNewTransactions();

+ IDBPendingTransactionMonitor::deactivateNewTransactions(isolate());

Heap::collectAllGarbage();

EXPECT_EQ(1u, set.size());

@@ -134,7 +134,7 @@ TEST_F(IDBTransactionTest, TransactionFinish)

Heap::collectAllGarbage();

EXPECT_EQ(1u, set.size());

- IDBPendingTransactionMonitor::from(*executionContext()).deactivateNewTransactions();

+ IDBPendingTransactionMonitor::deactivateNewTransactions(isolate());

Heap::collectAllGarbage();

EXPECT_EQ(1u, set.size());