Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 429453010: Drop V8RecursionScope dependency on ExecutionContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Factor out microtask fix/tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/Source/bindings/core/v8/V8PerIsolateData.cpp b/Source/bindings/core/v8/V8PerIsolateData.cpp
index b9241f0692fd4ba9c89acd5714f4cd0fdcd2deef..9c9a795e0f768fb976cf24c7a8115df66178fa7b 100644
--- a/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -118,7 +118,16 @@ v8::Persistent<v8::Value>& V8PerIsolateData::ensureLiveRoot()
return m_liveRoot.getUnsafe();
}
-void V8PerIsolateData::dispose(v8::Isolate* isolate)
+void V8PerIsolateData::willBeDestroyed(v8::Isolate* isolate)
+{
+ V8PerIsolateData* data = from(isolate);
+
+ // Clear any data that may have handles into the heap,
+ // prior to thread detach.
haraken 2014/09/11 01:18:53 thread detach => calling ThreadState::detach
jsbell 2014/09/11 22:14:51 Done.
+ data->m_idbPendingTransactionMonitor.clear();
+}
+
+void V8PerIsolateData::destroy(v8::Isolate* isolate)
{
#if ENABLE(ASSERT)
if (blink::Platform::current()->currentThread())

Powered by Google App Engine
This is Rietveld 408576698