Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: tools/telemetry/telemetry/core/browser_unittest.py

Issue 429453009: [Telemetry] Enable testDirtyProfileCreation on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser_unittest.py
diff --git a/tools/telemetry/telemetry/core/browser_unittest.py b/tools/telemetry/telemetry/core/browser_unittest.py
index 9a44089c55e36dbb7e2ad1201bc2297d3f0d898f..e0e70cea669baf649ba228b05b654e03caf170ca 100644
--- a/tools/telemetry/telemetry/core/browser_unittest.py
+++ b/tools/telemetry/telemetry/core/browser_unittest.py
@@ -26,14 +26,6 @@ class BrowserTest(unittest.TestCase):
options = options_for_unittests.GetCopy()
if profile_type:
- # TODO(jeremy): crbug.com/243912 profiles are only implemented on
- # Desktop.
- is_running_on_desktop = not (
- options.browser_type.startswith('android') or
- options.browser_type.startswith('cros'))
- if not is_running_on_desktop:
- logging.warn("Desktop-only test, skipping.")
- return None
options.browser_options.profile_type = profile_type
if extra_browser_args:
@@ -130,13 +122,9 @@ class BrowserTest(unittest.TestCase):
original_tab.Close()
self.assertEqual(b.foreground_tab, new_tab)
+ @benchmark.Disabled('chromeos') # crbug.com/243912
def testDirtyProfileCreation(self):
- b = self.CreateBrowser(profile_type = 'small_profile')
-
- # TODO(jeremy): crbug.com/243912 profiles are only implemented on Desktop
- if not b:
- return
-
+ b = self.CreateBrowser(profile_type='small_profile')
self.assertEquals(1, len(b.tabs))
def testGetSystemInfo(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698