Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 429453007: Add net to pairing DEPS (Closed)

Created:
6 years, 4 months ago by Zachary Kuznia
Modified:
6 years, 4 months ago
Reviewers:
wtc
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/pairing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zachary Kuznia
Please take a look. I'll be using net/base/io_buffer.h for BlocktoothSocket.
6 years, 4 months ago (2014-07-31 18:11:17 UTC) #1
wtc
Zachary: this should be fine, but I'd be interested in looking at your code that ...
6 years, 4 months ago (2014-07-31 19:51:06 UTC) #2
Zachary Kuznia
On 2014/07/31 19:51:06, wtc wrote: > Zachary: this should be fine, but I'd be interested ...
6 years, 4 months ago (2014-07-31 20:48:24 UTC) #3
wtc
Patch set 1 LGTM. It seems suboptimal to depend on "net" just for the IOBuffer ...
6 years, 4 months ago (2014-08-04 23:50:45 UTC) #4
Zachary Kuznia
6 years, 4 months ago (2014-08-06 17:24:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 287794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698