Issue 429453005: Do not include native Javascript in ExecutionState frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429453005: Do not include native Javascript in ExecutionState frames. (Closed)

Created:
6 years, 4 months ago by Yang

Modified:
6 years, 4 months ago

Reviewers:
aandrey

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Do not include native Javascript in ExecutionState frames. When a debug event is triggered, the ExecutionState object should not expose native JS code. R=aandrey@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22849

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comment #

Patch Set 3 : rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -29 lines)			Patch
	M	src/runtime.cc	View	1 2	4 chunks	+31 lines, -21 lines	0 comments	Download
	M	test/mjsunit/es6/debug-promise-events.js	View	1 2	3 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm w/ comments https://codereview.chromium.org/429453005/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/429453005/diff/1/src/runtime.cc#newcode11201 src/runtime.cc:11201: // Advances the iterator to to ...

6 years, 4 months ago (2014-07-31 14:43:17 UTC) #2

Yang

https://codereview.chromium.org/429453005/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/429453005/diff/1/src/runtime.cc#newcode11201 src/runtime.cc:11201: // Advances the iterator to to the frame that ...

6 years, 4 months ago (2014-07-31 15:27:10 UTC) #3

Yang

6 years, 4 months ago (2014-08-05 08:16:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22849 (presubmit successful).

Expand Messages | Collapse Messages