Let FrameSelection::localCaretRect on a text input field avoid synchronous layout.

Source/core/editing/PositionWithAffinity.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file./*
 
 #include "config.h"
 #include "core/editing/PositionWithAffinity.h"
+#include "core/rendering/InlineBox.h"
 
 namespace blink {
 
 PositionWithAffinity::PositionWithAffinity(const Position& position, EAffinity affinity)
     : m_position(position)
     , m_affinity(affinity)
 {
 }
 
 PositionWithAffinity::PositionWithAffinity()
     : m_affinity(DOWNSTREAM)
 {
 }
 
 PositionWithAffinity::~PositionWithAffinity()
 {
 }
 
+LayoutRect PositionWithAffinity::localCaretRect(RenderObject*& renderer) const

[yosin_UTC9, 2014/07/29 07:00:20]

It seems we can return just renderer and computing local caret rect on call
sites.

[yoichio, 2014/07/29 08:05:17]

calling localCaretRect uses local variables |inlineBox| and |caretOffset| so it
is not simple.

+{
+    if (m_position.isNull()) {
+        renderer = 0;

[yosin_UTC9, 2014/07/29 07:00:20]

nit: Let's use |nullptr|.

[yoichio, 2014/07/29 08:05:17]

Done.

+        return IntRect();
+    }
+    Node* node = m_position.anchorNode();
+
+    renderer = node->renderer();
+    if (!renderer)
+        return LayoutRect();
+
+    InlineBox* inlineBox;
+    int caretOffset;
+    m_position.getInlineBoxAndOffset(m_affinity, inlineBox, caretOffset);
+
+    if (inlineBox)
+        renderer = &inlineBox->renderer();
+
+    return renderer->localCaretRect(inlineBox, caretOffset);
+}
+
 void PositionWithAffinity::trace(Visitor* visitor)
 {
     visitor->trace(m_position);
 }
 
 } // namespace blink