Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/gn/target_generator.h

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clang warning Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target_generator.h
diff --git a/tools/gn/target_generator.h b/tools/gn/target_generator.h
index baee0f1114ca10a1858f968678b69b11b280f2fe..78e25645d02c774c0b28142a239fe580d8fe8635 100644
--- a/tools/gn/target_generator.h
+++ b/tools/gn/target_generator.h
@@ -54,6 +54,13 @@ class TargetGenerator {
void FillConfigs();
void FillOutputs();
+ // Rrturns true if the given pattern will expand to a file in the output
+ // directory. If not, returns false and sets the error, blaming the given
+ // Value.
+ bool EnsureSubstitutionIsInOutputDir(
+ const SubstitutionPattern& pattern,
+ const Value& original_value);
+
Target* target_;
Scope* scope_;
const FunctionCallNode* function_call_;

Powered by Google App Engine
This is Rietveld 408576698