Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: tools/gn/target_generator.h

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/substitution_writer_unittest.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_generator.h
diff --git a/tools/gn/target_generator.h b/tools/gn/target_generator.h
index baee0f1114ca10a1858f968678b69b11b280f2fe..7428a4dd5eda10a471ea5fa322a04063d4dad105 100644
--- a/tools/gn/target_generator.h
+++ b/tools/gn/target_generator.h
@@ -52,7 +52,14 @@ class TargetGenerator {
void FillPublic();
void FillInputs();
void FillConfigs();
- void FillOutputs();
+ void FillOutputs(bool allow_substitutions);
+
+ // Rrturns true if the given pattern will expand to a file in the output
+ // directory. If not, returns false and sets the error, blaming the given
+ // Value.
+ bool EnsureSubstitutionIsInOutputDir(
+ const SubstitutionPattern& pattern,
+ const Value& original_value);
Target* target_;
Scope* scope_;
« no previous file with comments | « tools/gn/substitution_writer_unittest.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698