Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: tools/gn/function_get_target_outputs_unittest.cc

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_get_target_outputs.cc ('k') | tools/gn/function_process_file_template.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_get_target_outputs_unittest.cc
diff --git a/tools/gn/function_get_target_outputs_unittest.cc b/tools/gn/function_get_target_outputs_unittest.cc
index 7c1b80c2e11b537a7af9a93d5e3fe683ade338c3..a38a17e1f0639211c23c63c3f2d9ca03e9a75027 100644
--- a/tools/gn/function_get_target_outputs_unittest.cc
+++ b/tools/gn/function_get_target_outputs_unittest.cc
@@ -86,8 +86,8 @@ TEST_F(GetTargetOutputsTest, Copy) {
Target* action = new Target(setup_.settings(), GetLabel("//foo/", "bar"));
action->set_output_type(Target::COPY_FILES);
action->sources().push_back(SourceFile("//file.txt"));
- action->action_values().outputs().push_back(
- "//out/Debug/{{source_file_part}}.one");
+ action->action_values().outputs() =
+ SubstitutionList::MakeForTest("//out/Debug/{{source_file_part}}.one");
items_.push_back(new scoped_ptr<Item>(action));
@@ -100,8 +100,9 @@ TEST_F(GetTargetOutputsTest, Copy) {
TEST_F(GetTargetOutputsTest, Action) {
Target* action = new Target(setup_.settings(), GetLabel("//foo/", "bar"));
action->set_output_type(Target::ACTION);
- action->action_values().outputs().push_back("//output1.txt");
- action->action_values().outputs().push_back("//output2.txt");
+ action->action_values().outputs() = SubstitutionList::MakeForTest(
+ "//output1.txt",
+ "//output2.txt");
items_.push_back(new scoped_ptr<Item>(action));
@@ -115,9 +116,8 @@ TEST_F(GetTargetOutputsTest, ActionForeach) {
Target* action = new Target(setup_.settings(), GetLabel("//foo/", "bar"));
action->set_output_type(Target::ACTION_FOREACH);
action->sources().push_back(SourceFile("//file.txt"));
- action->action_values().outputs().push_back(
- "//out/Debug/{{source_file_part}}.one");
- action->action_values().outputs().push_back(
+ action->action_values().outputs() = SubstitutionList::MakeForTest(
+ "//out/Debug/{{source_file_part}}.one",
"//out/Debug/{{source_file_part}}.two");
items_.push_back(new scoped_ptr<Item>(action));
« no previous file with comments | « tools/gn/function_get_target_outputs.cc ('k') | tools/gn/function_process_file_template.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698