Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/gn/escape.cc

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/copy_target_generator.cc ('k') | tools/gn/file_template.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/escape.cc
diff --git a/tools/gn/escape.cc b/tools/gn/escape.cc
index 7028a38b0b33f37b59d62d18b94010839872e76e..58bb04e7f771e7f207a3bb293d009ec74264d47e 100644
--- a/tools/gn/escape.cc
+++ b/tools/gn/escape.cc
@@ -46,8 +46,6 @@ void EscapeStringToString_Ninja(const base::StringPiece& str,
bool* needed_quoting) {
for (size_t i = 0; i < str.size(); i++)
NinjaEscapeChar(str[i], dest);
- if (needed_quoting)
- *needed_quoting = false;
}
// Escape for CommandLineToArgvW and additionally escape Ninja characters.
« no previous file with comments | « tools/gn/copy_target_generator.cc ('k') | tools/gn/file_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698