Refactor GN source expansions.

tools/gn/function_get_target_outputs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/build_settings.h"
-#include "tools/gn/file_template.h"
 #include "tools/gn/functions.h"
 #include "tools/gn/ninja_helper.h"
 #include "tools/gn/parse_tree.h"
 #include "tools/gn/settings.h"
+#include "tools/gn/substitution_writer.h"
 #include "tools/gn/target.h"
 #include "tools/gn/value.h"
 
 namespace functions {
 
 namespace {
 
 void GetOutputsForTarget(const Settings* settings,
                          const Target* target,
-                         std::vector<std::string>* ret) {
+                         std::vector<SourceFile>* ret) {
   switch (target->output_type()) {
     case Target::ACTION: {
-      // Actions: return the outputs specified.
-      const std::vector<std::string>& outs = target->action_values().outputs();
-      ret->reserve(outs.size());
-      for (size_t i = 0; i < outs.size(); i++)
-        ret->push_back(outs[i]);
+      // Actions just use the output list with no substitution. To keep things
+      // simple, pass an empty "source file" in to use the same code path for
+      // computing substitution outputs.
+      std::vector<SourceFile> sources;
+      sources.push_back(SourceFile());
+      SubstitutionWriter::ApplyListToSources(
+          settings, target->action_values().outputs(), sources, ret);

[scottmg, 2014/08/05 22:30:32]

What will happen if there is a substitution? Maybe a test for this case.

[brettw, 2014/08/06 18:25:01]

The thing that makes the target should prohibit this. I fixed this and added a
test.

       break;
     }
 
     case Target::COPY_FILES:
-    case Target::ACTION_FOREACH: {
-      // Copy/action_foreach: return the result of the template in the outputs.
-      FileTemplate file_template(settings, target->action_values().outputs(),
-                                 FileTemplate::OUTPUT_ABSOLUTE, SourceDir());
-      const std::vector<SourceFile>& sources = target->sources();
-      for (size_t i = 0; i < sources.size(); i++)
-        file_template.Apply(sources[i], ret);
+    case Target::ACTION_FOREACH:
+      SubstitutionWriter::ApplyListToSources(
+          settings, target->action_values().outputs(), target->sources(), ret);
       break;
-    }
 
     case Target::EXECUTABLE:
     case Target::SHARED_LIBRARY:
     case Target::STATIC_LIBRARY:
       // Return the resulting binary file. Currently, fall through to the
       // Ninja helper below which will compute the main output name.
       //
       // TODO(brettw) some targets have secondary files which should go into
       // the list after the main (like shared libraries on Windows have an
       // import library).
     case Target::GROUP:
     case Target::SOURCE_SET: {
       // These return the stamp file, which is computed by the NinjaHelper.
       NinjaHelper helper(settings->build_settings());
       OutputFile output_file = helper.GetTargetOutputFile(target);
 
       // The output file is relative to the build dir.
-      std::string absolute_output_file =
-          settings->build_settings()->build_dir().value();
-      absolute_output_file.append(output_file.value());
-
-      ret->push_back(absolute_output_file);
+      ret->push_back(SourceFile(
+          settings->build_settings()->build_dir().value() +
+          output_file.value()));
       break;
     }
 
     default:
       NOTREACHED();
   }
 }
 
 }  // namespace
 
@@ skipping 89 matching lines @@
   }
 
   if (!target) {
     *err = Err(function, "Target not found in this context.",
         label.GetUserVisibleName(false) +
         "\nwas not found. get_target_outputs() can only be used for targets\n"
         "previously defined in the current file.");
     return Value();
   }
 
-  std::vector<std::string> files;
+  std::vector<SourceFile> files;
   GetOutputsForTarget(scope->settings(), target, &files);
 
   Value ret(function, Value::LIST);
   ret.list_value().reserve(files.size());
   for (size_t i = 0; i < files.size(); i++)
-    ret.list_value().push_back(Value(function, files[i]));
+    ret.list_value().push_back(Value(function, files[i].value()));
 
   return ret;
 }
 
 }  // namespace functions