Issue 429363004: Should clear sheet when ProcessingInstruction's removedFrom or attributeChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429363004: Should clear sheet when ProcessingInstruction's removedFrom or attributeChanged (Closed)

Created:
6 years, 4 months ago by tasak

Modified:
6 years, 4 months ago

Reviewers:
dglazkov

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Should clear sheet when ProcessingInstruction's removedFrom or attributeChanged Added a new method: clearSheet to invoke removePendingSheet (if needed) and to clear ownerNode. BUG=398438, 400141 TEST=fast/xsl/modify-xsl-while-loading-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179786

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -4 lines)			Patch
A	LayoutTests/fast/xsl/modify-xsl-while-loading-crash.html	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/xsl/modify-xsl-while-loading-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.cpp	View	5 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/429363004/20001

6 years, 4 months ago (2014-08-08 03:48:29 UTC) #5

Message was sent while issue was closed.

Change committed as 179786

Expand Messages | Collapse Messages