tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ed36ee4f0fc824dde1900e60c4a0b6e0bf936c61..088d91b12031260f40fdbd6e840c6b280f192ac4 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -17528,6 +17528,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.DeviceConnectionStatus" enum="ConnectionStatus">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network performance metric that tracks the connection status of
+    the device. A sample is emitted once every 3 minutes.
+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.DHCPClientStatus" enum="NetworkDhcpClientStatus">
   <owner>pstew@chromium.org</owner>
   <summary>
@@ -18006,6 +18014,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.Wifi.NetworkProblemDetected"

[Ilya Sherman, 2014/07/31 22:08:13]

Is "Wifi" spelled correctly here?  It's odd that for some of the histograms you
use "Wifi" and others you use "WiFi".

+    enum="NetworkProblemType">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network performance metric that tracks the network problems
+    encountered by TrafficMonitor after wifi connection is established.

[Ilya Sherman, 2014/07/31 22:08:13]

nit: "wifi" -> "WiFi"

+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.Wifi.PhyMode" enum="NetworkPhyModeType">
   <owner>quiche@chromium.org</owner>
   <summary>
@@ -18178,6 +18195,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Network.Shill.WiFi.UserInitiatedConnectionFailureReason"
+    enum="ConnectionFailureReason">
+  <owner>zqiu@chromium.org</owner>
+  <summary>
+    Chrome OS network performance metric that tracks the reasons of failed
+    user-initiated wifi connection attempts.

[Ilya Sherman, 2014/07/31 22:08:13]

DItto.

[Ilya Sherman, 2014/07/31 22:08:14]

When is this logged -- just on an error?  What is the "success" baseline that
the error rate is relative to?

+  </summary>
+</histogram>
+
 <histogram name="Network.Shill.WiFi.UserInitiatedConnectionResult"
     enum="ConnectionResult">
   <owner>zqiu@chromium.org</owner>
@@ -36836,12 +36862,32 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="1" label="GPU compositor"/>
 </enum>
 
+<enum name="ConnectionFailureReason" type="int">
+  <int value="0" label="Unknown"/>
+  <int value="1" label="Bad Passphrase"/>
+  <int value="2" label="Bad WEP Key"/>
+  <int value="3" label="Failed to Connect"/>
+  <int value="4" label="DHCP Failure"/>
+  <int value="5" label="DNS Lookup Failure"/>
+  <int value="6" label="EAP Authentication"/>
+  <int value="7" label="EAP Local TLS"/>
+  <int value="8" label="EAP Remote TLS"/>
+  <int value="9" label="Out-of-range"/>
+  <int value="10" label="Pin Missing"/>
+</enum>
+
 <enum name="ConnectionResult" type="int">
   <int value="0" label="Success"/>
   <int value="1" label="Failure"/>
   <int value="2" label="Aborted"/>
 </enum>
 
+<enum name="ConnectionStatus" type="int">
+  <int value="0" label="Offline"/>
+  <int value="1" label="Connected"/>
+  <int value="2" label="Online"/>
+</enum>
+
 <enum name="ConnectionType" type="int">
   <summary>
     Connection type as defined in net/base/connection_type_histograms.h
@@ -43762,6 +43808,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="9" label="Unknown"/>
 </enum>
 
+<enum name="NetworkProblemType" type="int">
+  <int value="0" label="Congested TCP Queue"/>
+  <int value="1" label="DNS Failure"/>
+</enum>
+
 <enum name="NetworkSecurityType" type="int">
   <summary>
     The security types come from the connman_service_security enum in