Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: gm/patch.cpp

Issue 429343004: Stopped skipping tests in dm of SkPatch (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Added number of points and colors constants Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | src/utils/SkDumpCanvas.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/patch.cpp
diff --git a/gm/patch.cpp b/gm/patch.cpp
index 5658ef6a889d9d65788a708a7cff44e57259b9d6..3e3bf7a1b57fcc0c922a46e9758f215c8cd37ba9 100644
--- a/gm/patch.cpp
+++ b/gm/patch.cpp
@@ -62,7 +62,7 @@ static void draw_control_points(SkCanvas* canvas, SkPatch& patch, SkPaint& paint
static void draw_random_patch(SkPoint points[12], SkColor colors[4], SkCanvas* canvas,
SkPaint& paint, SkRandom* rnd) {
SkPoint ptsCpy[12];
mtklein 2014/08/04 20:40:47 Seems like we still have many 12's and 4's. It's
dandov 2014/08/04 21:47:54 I think I fixed all of the 12's and 4's that are r
- memcpy(ptsCpy, points, 12 * sizeof(SkPoint));
+ memcpy(ptsCpy, points, SkPatch::kNumCtrlPts * sizeof(SkPoint));
for (int i = 0; i < 5; i++) {
int index = rnd->nextRangeU(0, 11);
SkScalar dx = rnd->nextRangeScalar(-50, 50), dy = rnd->nextRangeScalar(-50, 50);
@@ -94,7 +94,7 @@ protected:
}
virtual uint32_t onGetFlags() const SK_OVERRIDE {
- return kSkipTiled_Flag | kSkipPipe_Flag | kSkipPicture_Flag;
+ return kSkipTiled_Flag;
}
virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE {
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | src/utils/SkDumpCanvas.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698