Stopped skipping tests in dm of SkPatch

src/core/SkPatch.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPatch.h"
 
 #include "SkGeometry.h"
 #include "SkColorPriv.h"
+#include "SkBuffer.h"
 
 ////////////////////////////////////////////////////////////////////////////////
 
 /**
  * Evaluator to sample the values of a cubic bezier using forward differences.
  * Forward differences is a method for evaluating a nth degree polynomial at a uniform step by only
  * adding precalculated values.
  * For a linear example we have the function f(t) = m*t+b, then the value of that function at t+h
  * would be f(t+h) = m*(t+h)+b. If we want to know the uniform step that we must add to the first
  * evaluation f(t) then we need to substract f(t+h) - f(t) = m*t + m*h + b - m*t + b = mh. After
@@ skipping 88 matching lines @@
         return fPoints;
     }
     
 private:
     int fMax, fCurrent, fDivisions;
     SkPoint fFwDiff[4], fCoefs[4], fPoints[4];
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 
-SkPatch::SkPatch(SkPoint points[12], SkColor colors[4]) {
-        
-    for (int i = 0; i < 12; i++) {
-        fCtrlPoints[i] = points[i];
-    }
-    for (int i = 0; i < 4; i++) {
-        fCornerColors[i] = colors[i];
-    }
-    
+SkPatch::SkPatch(const SkPoint points[12], const SkColor colors[4]) {
+    this->reset(points, colors);
 }
 
 uint8_t bilinear(SkScalar tx, SkScalar ty, SkScalar c00, SkScalar c10, SkScalar c01, SkScalar c11) {
     SkScalar a = c00 * (1.f - tx) + c10 * tx;
     SkScalar b = c01 * (1.f - tx) + c11 * tx;
     return uint8_t(a * (1.f - ty) + b * ty);
 }
 
 bool SkPatch::getVertexData(SkPatch::VertexData* data, int lodX, int lodY) const {
     
     if (lodX < 1 || lodY < 1) {
         return false;
     }
     
     // premultiply colors to avoid color bleeding. 
-    SkPMColor colors[4];
-    for (int i = 0; i < 4; i++) {
+    SkPMColor colors[SkPatch::kNumColors];
+    for (int i = 0; i < SkPatch::kNumColors; i++) {
         colors[i] = SkPreMultiplyColor(fCornerColors[i]);
     }
     
     // number of indices is limited by size of uint16_t, so we clamp it to avoid overflow
     data->fVertexCount = SkMin32((lodX + 1) * (lodY + 1), 65536);
     lodX  = SkMin32(lodX, 255);
     lodY  = SkMin32(lodY, 255);
     data->fIndexCount = lodX * lodY * 6;
 
     data->fPoints = SkNEW_ARRAY(SkPoint, data->fVertexCount);
     data->fColors = SkNEW_ARRAY(uint32_t, data->fVertexCount);
     data->fTexCoords = SkNEW_ARRAY(SkPoint, data->fVertexCount);
     data->fIndices = SkNEW_ARRAY(uint16_t, data->fIndexCount);
     
-    SkPoint pts[4];
+    SkPoint pts[SkPatch::kNumPtsCubic];
     this->getBottomPoints(pts);
     FwDCubicEvaluator fBottom(pts);
     this->getTopPoints(pts);
     FwDCubicEvaluator fTop(pts);
     this->getLeftPoints(pts);
     FwDCubicEvaluator fLeft(pts);
     this->getRightPoints(pts);
     FwDCubicEvaluator fRight(pts);
 
     fBottom.restart(lodX);
@@ skipping 58 matching lines @@
                 data->fIndices[i + 3] = data->fIndices[i];
                 data->fIndices[i + 4] = data->fIndices[i + 2];
                 data->fIndices[i + 5] = (x + 1) * stride + y;
             }
             v = SkScalarClampMax(v + 1.f / lodY, 1);
         }
         u = SkScalarClampMax(u + 1.f / lodX, 1);
     }
     return true;
 }
+
+size_t SkPatch::writeToMemory(void* storage) const {
+    int byteCount =  kNumCtrlPts * sizeof(SkPoint) + kNumColors * sizeof(SkColor);
+    
+    if (NULL == storage) {
+        return SkAlign4(byteCount);
+    }
+    
+    SkWBuffer buffer(storage);
+    
+    buffer.write(fCtrlPoints, kNumCtrlPts * sizeof(SkPoint));
+    buffer.write(fCornerColors, kNumColors * sizeof(SkColor));
+    
+    buffer.padToAlign4();
+    return buffer.pos();
+}
+
+size_t SkPatch::readFromMemory(const void* storage, size_t length) {
+    SkRBufferWithSizeCheck buffer(storage, length);
+    
+    int byteCount = 0;
+    
+    if (!buffer.read(fCtrlPoints, kNumCtrlPts * sizeof(SkPoint))) {

[robertphillips, 2014/08/05 15:42:00]

By the header comment - aren't we supposed to return 0 here ?

[dandov, 2014/08/05 17:34:05]

Done.

+        return byteCount;
+    }
+    byteCount += kNumCtrlPts * sizeof(SkPoint);
+    
+    if (!buffer.read(fCornerColors, kNumColors * sizeof(SkColor))) {

[robertphillips, 2014/08/05 15:42:00]

And here ?

[dandov, 2014/08/05 17:34:05]

Done.

+        return byteCount;
+    }
+    byteCount += kNumColors * sizeof(SkColor);
+    
+    return byteCount;
+}