Stopped skipping tests in dm of SkPatch

gm/patch.cpp

 
 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 // This test only works with the GPU backend.
 
 #include "gm.h"
 
 #if SK_SUPPORT_GPU
 
 #include "GrContext.h"
 #include "GrTest.h"
 #include "SkPatch.h"
 

[robertphillips, 2014/08/05 12:44:45]

const SkPatch& patch, const SkPaint& paint ?
If you want to modify a method parameter you need to pass it as a pointer (at
least in Skia's coding standard).

[dandov, 2014/08/05 14:27:11]

Done.

 static void draw_control_points(SkCanvas* canvas, SkPatch& patch, SkPaint& paint) {
     //draw control points
     SkPaint copy(paint);

[robertphillips, 2014/08/05 12:44:45]

This is a bit odd. I would expect this to be kNumPtsCubic rather then
kNumColors.

[dandov, 2014/08/05 14:27:11]

Done.

-    SkPoint bottom[4];
+    SkPoint bottom[SkPatch::kNumColors];
     patch.getBottomPoints(bottom);
-    SkPoint top[4];
+    SkPoint top[SkPatch::kNumColors];
     patch.getTopPoints(top);
-    SkPoint left[4];
+    SkPoint left[SkPatch::kNumColors];
     patch.getLeftPoints(left);
-    SkPoint right[4];
+    SkPoint right[SkPatch::kNumColors];
     patch.getRightPoints(right);
 
     copy.setColor(SK_ColorBLACK);
     copy.setStrokeWidth(0.5);
     SkPoint corners[4] = { bottom[0], bottom[3], top[0], top[3] };
     canvas->drawPoints(SkCanvas::kLines_PointMode, 4, bottom, copy);
     canvas->drawPoints(SkCanvas::kLines_PointMode, 2, bottom+1, copy);
     canvas->drawPoints(SkCanvas::kLines_PointMode, 4, top, copy);
     canvas->drawPoints(SkCanvas::kLines_PointMode, 4, left, copy);
     canvas->drawPoints(SkCanvas::kLines_PointMode, 4, right, copy);
@@ skipping 12 matching lines @@
 
     copy.setColor(SK_ColorCYAN);
     canvas->drawPoints(SkCanvas::kPoints_PointMode, 2, top+1, copy);
 
     copy.setColor(SK_ColorYELLOW);
     canvas->drawPoints(SkCanvas::kPoints_PointMode, 2, left+1, copy);
 
     copy.setColor(SK_ColorGREEN);
     canvas->drawPoints(SkCanvas::kPoints_PointMode, 2, right+1, copy);
 }
 

[robertphillips, 2014/08/05 12:44:45]

// Randomly alter 5 of the control points of the provided set and then draw the
result ?
Make points, colors and paint all const parameters ?

[dandov, 2014/08/05 14:27:11]

Made them all constant and removed function draw_random_patch.

-static void draw_random_patch(SkPoint points[12], SkColor colors[4], SkCanvas* canvas,
-                              SkPaint& paint, SkRandom* rnd) {
-    SkPoint ptsCpy[12];
-    memcpy(ptsCpy, points, 12 * sizeof(SkPoint));
+static void draw_random_patch(SkPoint points[SkPatch::kNumCtrlPts],
+                              SkColor colors[SkPatch::kNumColors], SkCanvas* canvas, SkPaint& paint,
+                              SkRandom* rnd) {
+    SkPoint ptsCpy[SkPatch::kNumCtrlPts];
+    memcpy(ptsCpy, points, SkPatch::kNumCtrlPts * sizeof(SkPoint));
     for (int i = 0; i < 5; i++) {
         int index = rnd->nextRangeU(0, 11);

[robertphillips, 2014/08/05 12:44:44]

Move dy to its own line ?

[dandov, 2014/08/05 14:27:11]

Done.

         SkScalar dx = rnd->nextRangeScalar(-50, 50), dy = rnd->nextRangeScalar(-50, 50);
         ptsCpy[index].offset(dx, dy);
     }
     SkPatch patch(ptsCpy, colors);
     canvas->drawPatch(patch, paint);
     draw_control_points(canvas, patch, paint);
 }
 
 namespace skiagm {
 /**
  * This GM draws a SkPatch.
  */
 class SkPatchGM : public GM {
     
 public:
     SkPatchGM() {
         this->setBGColor(0xFFFFFFFF);
     }
 
 protected:
     virtual SkString onShortName() SK_OVERRIDE {
         return SkString("patch_primitive");
     }
 
     virtual SkISize onISize() SK_OVERRIDE {
         return SkISize::Make(800, 800);
     }
 
     virtual uint32_t onGetFlags() const SK_OVERRIDE {
-        return kSkipTiled_Flag | kSkipPipe_Flag | kSkipPicture_Flag;
+        return kSkipTiled_Flag;
     }
     
     virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE {
         
         SkPaint paint;
-        SkColor colors[4] = {
+        SkColor colors[SkPatch::kNumColors] = {
             SK_ColorRED, SK_ColorGREEN, SK_ColorBLUE, SK_ColorCYAN
         };

[robertphillips, 2014/08/05 12:44:45]

// Order is clockwise starting at the UL corner

[dandov, 2014/08/05 14:27:10]

Done.

-        SkPoint points[12] = {
+        SkPoint points[SkPatch::kNumCtrlPts] = {

[robertphillips, 2014/08/05 12:44:45]

Label this with "// top" on RHS ?

[dandov, 2014/08/05 14:27:11]

Done.

             {50,50},{75,20},{125,80}, {150,50},
             {120,75},{180,125},{150,150},

[robertphillips, 2014/08/05 12:44:45]

Move the "{150,150}" down to the next line and label with "// bottom" ?

[dandov, 2014/08/05 14:27:11]

Done.

             {125,120},{75,180},{50,150},

[robertphillips, 2014/08/05 12:44:45]

Label this with "// left" on RHS ?

[dandov, 2014/08/05 14:27:11]

Done.

             {20,125},{80,75}
         };
         
         SkRandom rnd;

[robertphillips, 2014/08/05 12:44:45]

static const SkScalar kScale = 0.5f; ?

[dandov, 2014/08/05 14:27:10]

Done.

         SkScalar scale = 0.5f;
         canvas->save();
         for (SkScalar x = 0; x < 4; x++) {
             canvas->save();
             canvas->scale(scale * (x + 1), scale * (x + 1));
             canvas->translate(x * 100, 0);
             draw_random_patch(points, colors, canvas, paint, &rnd);
             canvas->restore();
         }
         canvas->translate(0, 270);

[robertphillips, 2014/08/05 12:44:45]

static const SkScalar kSkew = 0.1f; ?

[dandov, 2014/08/05 14:27:11]

Done.

         SkScalar skew = 0.1f;
         for (SkScalar x = 0; x < 4; x++) {
             canvas->save();
             canvas->scale(scale * (x + 1), scale * (x + 1));
             canvas->skew(skew * (x + 1), skew * (x + 1));
             canvas->translate(x * 100, 0);
             draw_random_patch(points, colors, canvas, paint, &rnd);
             canvas->restore();
         }
         canvas->restore();
     }
 
 private:
     typedef GM INHERITED;
 };
 
 DEF_GM(return SkNEW(SkPatchGM); )
 
 }
 
 #endif