runtime/bin/vmservice/client/lib/src/service/object.dart - Issue 429293002: Add request tracing to Observatory:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 429293002: Add request tracing to Observatory: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/service/object.dart

diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart

index 01ebe5f59a2c179611844b41ee9290918e3d488d..a995734b2d207f357303ba477fbc01cef7ffe9c6 100644

--- a/runtime/bin/vmservice/client/lib/src/service/object.dart

+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart

@@ -416,6 +416,9 @@ abstract class VM extends ServiceObjectOwner {

Future<ObservableMap> getAsMap(String id) {

return getString(id).then((response) {

var map = _parseJSON(response);

+ if (Tracer.current != null) {

+ Tracer.current.trace("Received response for ${id}", map:map);

+ }

return _processMap(map);

}).catchError((error) {

// ServiceError, forward to VM's ServiceError stream.