Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 429243003: Updates analyzer to output to a file (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Updates analyzer to output to a file File is specified by way of analyzer_output_path. I'm also changing from a hard error if a target can't be found to a warning. I'm also including a new set of tests. I forgot to svn add this last time around. BUG=109173 TEST=covered by tests R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1959

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -7 lines) Patch
M pylib/gyp/generator/analyzer.py View 4 chunks +32 lines, -7 lines 0 comments Download
A test/analyzer/gyptest-analyzer.new.py View 1 1 chunk +199 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 4 months ago (2014-07-30 16:57:01 UTC) #1
Mark Mentovai
LGTM
6 years, 4 months ago (2014-07-30 17:01:56 UTC) #2
sky
Updated to not trip over pylint warnings by no subclassing a test. I'm going to ...
6 years, 4 months ago (2014-07-30 20:27:22 UTC) #3
sky
Committed patchset #2 manually as r1959 (presubmit successful).
6 years, 4 months ago (2014-07-30 20:29:35 UTC) #4
Mark Mentovai
6 years, 4 months ago (2014-07-30 20:29:43 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698