Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Side by Side Diff: Source/bindings/v8/DOMWrapperMap.h

Issue 429233002: Merge 178823 "Replace further questionable HashMap::add usages i..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2062/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/v8/SerializedScriptValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 static Iterator End(Impl* impl) { return impl->end(); } 100 static Iterator End(Impl* impl) { return impl->end(); }
101 static v8::PersistentContainerValue Value(Iterator& iter) 101 static v8::PersistentContainerValue Value(Iterator& iter)
102 { 102 {
103 return iter->value; 103 return iter->value;
104 } 104 }
105 static KeyType* Key(Iterator& iter) { return iter->key; } 105 static KeyType* Key(Iterator& iter) { return iter->key; }
106 static v8::PersistentContainerValue Set( 106 static v8::PersistentContainerValue Set(
107 Impl* impl, KeyType* key, v8::PersistentContainerValue value) 107 Impl* impl, KeyType* key, v8::PersistentContainerValue value)
108 { 108 {
109 v8::PersistentContainerValue oldValue = Get(impl, key); 109 v8::PersistentContainerValue oldValue = Get(impl, key);
110 impl->add(key, value); 110 impl->set(key, value);
111 return oldValue; 111 return oldValue;
112 } 112 }
113 static v8::PersistentContainerValue Get(const Impl* impl, KeyType* key) 113 static v8::PersistentContainerValue Get(const Impl* impl, KeyType* key)
114 { 114 {
115 return impl->get(key); 115 return impl->get(key);
116 } 116 }
117 117
118 static v8::PersistentContainerValue Remove(Impl* impl, KeyType* key) 118 static v8::PersistentContainerValue Remove(Impl* impl, KeyType* key)
119 { 119 {
120 return impl->take(key); 120 return impl->take(key);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 v8::UniquePersistent<v8::Object> value, 160 v8::UniquePersistent<v8::Object> value,
161 void* key) 161 void* key)
162 { 162 {
163 RELEASE_ASSERT(!value.IsEmpty()); // See crbug.com/368095. 163 RELEASE_ASSERT(!value.IsEmpty()); // See crbug.com/368095.
164 releaseObject(v8::Local<v8::Object>::New(isolate, value)); 164 releaseObject(v8::Local<v8::Object>::New(isolate, value));
165 } 165 }
166 166
167 } // namespace WebCore 167 } // namespace WebCore
168 168
169 #endif // DOMWrapperMap_h 169 #endif // DOMWrapperMap_h
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/SerializedScriptValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698