Issue 429203002: Turn ASSERTs in platform setup releated code into CHECKs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429203002: Turn ASSERTs in platform setup releated code into CHECKs (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Turn ASSERTs in platform setup releated code into CHECKs This way, we will already catch misconfigurations in release builds, instead of getting random bug reports way later during runtime. BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22734

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/v8.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

6 years, 4 months ago (2014-07-31 08:06:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22734 (tree was closed).

Expand Messages | Collapse Messages