Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 429173003: Resubmit: Remove deprecated extension notification from WebstoreStartupInstallerTest (Closed)

Created:
6 years, 4 months ago by limasdf
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Resubmit: Remove deprecated extension notification from WebstoreStartupInstallerTest This CL fixes the previous reverted CL#437603002. To fix, removed ExtensionRegistryObserver from TearDownOnMainThread instead of destructor. R=kalman@chromium.org BUG=354046 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287414

Patch Set 1 #

Total comments: 2

Patch Set 2 : review1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 1 4 chunks +25 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
limasdf
Benjamin, PTAL! CC:jamescook, Thanks for the hint!
6 years, 4 months ago (2014-08-04 10:48:24 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/429173003/diff/1/chrome/browser/extensions/webstore_startup_installer_browsertest.cc File chrome/browser/extensions/webstore_startup_installer_browsertest.cc (right): https://codereview.chromium.org/429173003/diff/1/chrome/browser/extensions/webstore_startup_installer_browsertest.cc#newcode260 chrome/browser/extensions/webstore_startup_installer_browsertest.cc:260: ->RemoveObserver(this); also run WebstoreStartupInstallerTest::TearDownOnMainThread() after this.
6 years, 4 months ago (2014-08-04 15:46:05 UTC) #2
limasdf
https://codereview.chromium.org/429173003/diff/1/chrome/browser/extensions/webstore_startup_installer_browsertest.cc File chrome/browser/extensions/webstore_startup_installer_browsertest.cc (right): https://codereview.chromium.org/429173003/diff/1/chrome/browser/extensions/webstore_startup_installer_browsertest.cc#newcode260 chrome/browser/extensions/webstore_startup_installer_browsertest.cc:260: ->RemoveObserver(this); On 2014/08/04 15:46:05, kalman wrote: > also run ...
6 years, 4 months ago (2014-08-04 16:38:09 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 4 months ago (2014-08-04 16:38:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/429173003/20001
6 years, 4 months ago (2014-08-04 16:38:40 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:12:29 UTC) #6
Message was sent while issue was closed.
Change committed as 287414

Powered by Google App Engine
This is Rietveld 408576698