Issue 42913002: Try to work around bug in glib by ensuring DBUS_SESSION_BUS_ADDRESS is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42913002: Try to work around bug in glib by ensuring DBUS_SESSION_BUS_ADDRESS is set. (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
7 years, 1 month ago

Reviewers:
dtu

CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, jln (very slow on Chromium), bajones, Zhenyao Mo, agable

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Try to work around bug in glib by ensuring DBUS_SESSION_BUS_ADDRESS is set. BUG=309093 R=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230904

Patch Set 2 : Addressed dtu's review feedback. #

Total comments: 1

Patch Set 3 : Nit. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	content/test/gpu/run_gpu_test	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dtu

lgtm with nit https://codereview.chromium.org/42913002/diff/1/content/test/gpu/run_gpu_test File content/test/gpu/run_gpu_test (right): https://codereview.chromium.org/42913002/diff/1/content/test/gpu/run_gpu_test#newcode8 content/test/gpu/run_gpu_test:8: # Attempt to work around bug ...

7 years, 1 month ago (2013-10-25 01:42:31 UTC) #2

dtu

Thanks, still one nit :P still lgtm https://codereview.chromium.org/42913002/diff/50001/content/test/gpu/run_gpu_test File content/test/gpu/run_gpu_test (right): https://codereview.chromium.org/42913002/diff/50001/content/test/gpu/run_gpu_test#newcode8 content/test/gpu/run_gpu_test:8: def do_dbus_workaround(): ...

7 years, 1 month ago (2013-10-25 01:51:18 UTC) #3

Ken Russell (switch to Gerrit)

7 years, 1 month ago (2013-10-25 01:54:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r230904 (presubmit successful).