[GCM] Persistence of account mappings.

[GCM] Persistence of account mappings.

* Adding ability to add, remove and load account info
to device mappings in GCMStore with Tests.
* Moving the code resetting load results to LoadResult
structure (fixed a bug where last_checkin_accounts
where not cleared upon failure to load)

R=zea@chromium.org
BUG=374969
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287391

[fgorski, 2014-07-30 18:49:36]

Nicolas, PTAL.

I am currently fixing the comments from self-review.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
File google_apis/gcm/engine/gcm_store_impl.cc (right):

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:111: return
key.substr(arraysize(kAccountKeyEnd) - 1);
Auto-complete bug. Fix to kAccountKeyStart

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:594: if (s.ok())
negate condition.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:595: LOG(ERROR) << "LevelDB account
info update failed: " << s.ToString();
LevelDB adding of account mapping failed:

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:615: LOG(ERROR) << "LevelDB remove
failed: " << s.ToString();
rephrase to LevelDB removal of account mapping failed:

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:808: DVLOG(1) << "Found account info
with ID: " << account_info.account_id;
Found account mapping ...

[fgorski, 2014-07-30 20:18:49]

Done.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
File google_apis/gcm/engine/gcm_store_impl.cc (right):

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:111: return
key.substr(arraysize(kAccountKeyEnd) - 1);
On 2014/07/30 18:49:36, fgorski wrote:
> Auto-complete bug. Fix to kAccountKeyStart

Done.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:594: if (s.ok())
On 2014/07/30 18:49:36, fgorski wrote:
> negate condition.

Done.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:595: LOG(ERROR) << "LevelDB account
info update failed: " << s.ToString();
On 2014/07/30 18:49:36, fgorski wrote:
> LevelDB adding of account mapping failed: 

Done.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:615: LOG(ERROR) << "LevelDB remove
failed: " << s.ToString();
On 2014/07/30 18:49:36, fgorski wrote:
> rephrase to LevelDB removal of account mapping failed: 

Done.

https://codereview.chromium.org/429073002/diff/20001/google_apis/gcm/engine/g...
google_apis/gcm/engine/gcm_store_impl.cc:808: DVLOG(1) << "Found account info
with ID: " << account_info.account_id;
On 2014/07/30 18:49:36, fgorski wrote:
> Found account mapping ...

Done.

[Nicolas Zea, 2014-07-30 20:31:03]

lgtm

[fgorski, 2014-07-30 20:32:35]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-07-30 20:59:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/429073002/40001

[commit-bot: I haz the power, 2014-07-31 01:12:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-31 01:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 01:22:22]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2014-07-31 14:21:11]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-07-31 14:21:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/429073002/40001

[commit-bot: I haz the power, 2014-07-31 14:31:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-31 14:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 14:39:19]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2014-07-31 19:11:39]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-07-31 19:14:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/429073002/40001

[commit-bot: I haz the power, 2014-07-31 19:25:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-31 19:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 19:34:31]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fgorski, 2014-08-04 15:58:28]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-08-04 15:59:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/429073002/60001

[commit-bot: I haz the power, 2014-08-04 19:35:25]

Change committed as 287391